lib: simplify sbi_fifo_inplace_update()

Don't assign an unused value to variable index.

Use operator '-=' where applicable.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
Reviewed-by: Xiang W <wxjstz@126.com>

diff --git a/lib/sbi/sbi_fifo.c b/lib/sbi/sbi_fifo.c
index 2a5c012..b2395f3 100644 (file)
--- a/lib/sbi/sbi_fifo.c
+++ b/lib/sbi/sbi_fifo.c
@@ -118,7 +118,7 @@ bool sbi_fifo_reset(struct sbi_fifo *fifo)
 int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
                            int (*fptr)(void *in, void *data))
 {
-       int i, index = 0;
+       int i, index;
        int ret = SBI_FIFO_UNCHANGED;
        void *entry;
 
@@ -135,7 +135,7 @@ int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
        for (i = 0; i < fifo->avail; i++) {
                index = fifo->tail + i;
                if (index >= fifo->num_entries)
-                       index = index - fifo->num_entries;
+                       index -= fifo->num_entries;
                entry = (void *)fifo->queue + (u32)index * fifo->entry_size;
                ret = fptr(in, entry);