hns3: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Aug 2019 10:17:22 +0000 (12:17 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Aug 2019 22:25:48 +0000 (15:25 -0700)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c

index 7996dcc..7070d25 100644 (file)
@@ -376,20 +376,11 @@ static const struct file_operations hns3_dbg_cmd_fops = {
 void hns3_dbg_init(struct hnae3_handle *handle)
 {
        const char *name = pci_name(handle->pdev);
-       struct dentry *pfile;
 
        handle->hnae3_dbgfs = debugfs_create_dir(name, hns3_dbgfs_root);
-       if (!handle->hnae3_dbgfs)
-               return;
 
-       pfile = debugfs_create_file("cmd", 0600, handle->hnae3_dbgfs, handle,
-                                   &hns3_dbg_cmd_fops);
-       if (!pfile) {
-               debugfs_remove_recursive(handle->hnae3_dbgfs);
-               handle->hnae3_dbgfs = NULL;
-               dev_warn(&handle->pdev->dev, "create file for %s fail\n",
-                        name);
-       }
+       debugfs_create_file("cmd", 0600, handle->hnae3_dbgfs, handle,
+                           &hns3_dbg_cmd_fops);
 }
 
 void hns3_dbg_uninit(struct hnae3_handle *handle)
@@ -401,10 +392,6 @@ void hns3_dbg_uninit(struct hnae3_handle *handle)
 void hns3_dbg_register_debugfs(const char *debugfs_dir_name)
 {
        hns3_dbgfs_root = debugfs_create_dir(debugfs_dir_name, NULL);
-       if (!hns3_dbgfs_root) {
-               pr_warn("Register debugfs for %s fail\n", debugfs_dir_name);
-               return;
-       }
 }
 
 void hns3_dbg_unregister_debugfs(void)