mwifiex: drop redundant null-pointer check in mwifiex_dnld_cmd_to_fw()
authorTuo Li <islituo@gmail.com>
Wed, 4 Aug 2021 02:03:05 +0000 (19:03 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 21 Aug 2021 17:49:20 +0000 (20:49 +0300)
There is no case in which the variable cmd_node->cmd_skb has no ->data,
and thus the variable host_cmd is guaranteed to be not NULL. Therefore,
the null-pointer check is redundant and can be dropped.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Tuo Li <islituo@gmail.com>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210804020305.29812-1-islituo@gmail.com
drivers/net/wireless/marvell/mwifiex/cmdevt.c

index 3a11342..171a257 100644 (file)
@@ -187,7 +187,7 @@ static int mwifiex_dnld_cmd_to_fw(struct mwifiex_private *priv,
        host_cmd = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data);
 
        /* Sanity test */
-       if (host_cmd == NULL || host_cmd->size == 0) {
+       if (host_cmd->size == 0) {
                mwifiex_dbg(adapter, ERROR,
                            "DNLD_CMD: host_cmd is null\t"
                            "or cmd size is 0, not sending\n");