net: phy: mscc: make some arrays static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Sun, 1 Aug 2021 07:01:55 +0000 (08:01 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Aug 2021 16:15:07 +0000 (09:15 -0700)
Don't populate arrays on the stack but instead them static const.
Makes the object code smaller by 280 bytes.

Before:
   text    data     bss     dec     hex filename
  24142    4368     192   28702    701e ./drivers/net/phy/mscc/mscc_ptp.o

After:
   text    data     bss     dec     hex filename
  23830    4400     192   28422    6f06 ./drivers/net/phy/mscc/mscc_ptp.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210801070155.139057-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/mscc/mscc_ptp.c

index 924ed5b034a49ca3d29f1823dee028efd0df001c..edb951695b13e1cb13278bb80cd26b3df2162c3b 100644 (file)
@@ -506,7 +506,7 @@ static int vsc85xx_ptp_cmp_init(struct phy_device *phydev, enum ts_blk blk)
 {
        struct vsc8531_private *vsc8531 = phydev->priv;
        bool base = phydev->mdio.addr == vsc8531->ts_base_addr;
-       u8 msgs[] = {
+       static const u8 msgs[] = {
                PTP_MSGTYPE_SYNC,
                PTP_MSGTYPE_DELAY_REQ
        };
@@ -847,7 +847,7 @@ static int vsc85xx_ts_ptp_action_flow(struct phy_device *phydev, enum ts_blk blk
 static int vsc85xx_ptp_conf(struct phy_device *phydev, enum ts_blk blk,
                            bool one_step, bool enable)
 {
-       u8 msgs[] = {
+       static const u8 msgs[] = {
                PTP_MSGTYPE_SYNC,
                PTP_MSGTYPE_DELAY_REQ
        };
@@ -1268,8 +1268,8 @@ static void vsc8584_set_input_clk_configured(struct phy_device *phydev)
 static int __vsc8584_init_ptp(struct phy_device *phydev)
 {
        struct vsc8531_private *vsc8531 = phydev->priv;
-       u32 ltc_seq_e[] = { 0, 400000, 0, 0, 0 };
-       u8  ltc_seq_a[] = { 8, 6, 5, 4, 2 };
+       static const u32 ltc_seq_e[] = { 0, 400000, 0, 0, 0 };
+       static const u8  ltc_seq_a[] = { 8, 6, 5, 4, 2 };
        u32 val;
 
        if (!vsc8584_is_1588_input_clk_configured(phydev)) {