net: cleanup vlan_features setting in register_netdev
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>
Thu, 14 Jul 2011 21:41:11 +0000 (14:41 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Jul 2011 21:41:11 +0000 (14:41 -0700)
vlan_features contains features inherited from underlying device.
NETIF_SOFT_FEATURES are not inherited but belong to the vlan device
itself (ensured in vlan_dev_fix_features()).

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c

index 9ca1514..e57be02 100644 (file)
@@ -5488,12 +5488,9 @@ int register_netdevice(struct net_device *dev)
                dev->features |= NETIF_F_NOCACHE_COPY;
        }
 
-       /* Enable GSO, GRO and NETIF_F_HIGHDMA for vlans by default,
-        * vlan_dev_fix_features() will do the features check,
-        * so NETIF_F_HIGHDMA feature is enabled only if supported
-        * by underlying device.
+       /* Make NETIF_F_HIGHDMA inheritable to VLAN devices.
         */
-       dev->vlan_features |= (NETIF_F_SOFT_FEATURES | NETIF_F_HIGHDMA);
+       dev->vlan_features |= NETIF_F_HIGHDMA;
 
        ret = call_netdevice_notifiers(NETDEV_POST_INIT, dev);
        ret = notifier_to_errno(ret);