f2fs: check all the data segments against all node ones
authorSurbhi Palande <f2fsnewbie@gmail.com>
Fri, 23 Aug 2019 22:40:45 +0000 (15:40 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 16 Sep 2019 15:38:48 +0000 (08:38 -0700)
As a part of the sanity checking while mounting, distinct segment number
assignment to data and node segments is verified. Fixing a small bug in
this verification between node and data segments. We need to check all
the data segments with all the node segments.

Fixes: 042be0f849e5f ("f2fs: fix to do sanity check with current segment number")
Signed-off-by: Surbhi Palande <csurbhi@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/super.c

index 46d10a9..04788a6 100644 (file)
@@ -2738,10 +2738,10 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
                }
        }
        for (i = 0; i < NR_CURSEG_NODE_TYPE; i++) {
-               for (j = i; j < NR_CURSEG_DATA_TYPE; j++) {
+               for (j = 0; j < NR_CURSEG_DATA_TYPE; j++) {
                        if (le32_to_cpu(ckpt->cur_node_segno[i]) ==
                                le32_to_cpu(ckpt->cur_data_segno[j])) {
-                               f2fs_err(sbi, "Data segment (%u) and Data segment (%u) has the same segno: %u",
+                               f2fs_err(sbi, "Node segment (%u) and Data segment (%u) has the same segno: %u",
                                         i, j,
                                         le32_to_cpu(ckpt->cur_node_segno[i]));
                                return 1;