mt76: mt7915: fix possible infinite loop release semaphore
authorLorenzo Bianconi <lorenzo@kernel.org>
Tue, 14 Sep 2021 16:42:51 +0000 (18:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 13:04:08 +0000 (14:04 +0100)
[ Upstream commit e500c9470e26be66eb2bc6de773ae9091149118a ]

Fix possible infinite loop in mt7915_load_patch if
mt7915_mcu_patch_sem_ctrl always returns an error.

Fixes: e57b7901469fc ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

index 7c2d09a..c36c7b0 100644 (file)
@@ -2648,7 +2648,7 @@ out:
        default:
                ret = -EAGAIN;
                dev_err(dev->mt76.dev, "Failed to release patch semaphore\n");
-               goto out;
+               break;
        }
        release_firmware(fw);