drm/amd/display: Add psr get_state call
authorWyatt Wood <wyatt.wood@amd.com>
Mon, 20 Jan 2020 20:52:44 +0000 (15:52 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 11 Feb 2020 16:50:55 +0000 (11:50 -0500)
[Why]
Driver needs to know PSR state.

[How]
Use GPINT to call to firmware and get psr state.

Signed-off-by: Wyatt Wood <wyatt.wood@amd.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link.c
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h

index 66d8d56..24d9984 100644 (file)
@@ -2451,7 +2451,7 @@ bool dc_link_get_psr_state(const struct dc_link *link, uint32_t *psr_state)
        struct dmub_psr *psr = dc->res_pool->psr;
 
        if (psr != NULL && link->psr_feature_enabled)
-               psr->funcs->psr_get_state(psr_state);
+               psr->funcs->psr_get_state(psr, psr_state);
        else if (dmcu != NULL && link->psr_feature_enabled)
                dmcu->funcs->get_psr_state(dmcu, psr_state);
 
index cacb469..22cd68f 100644 (file)
 #include "../../dmub/inc/dmub_srv.h"
 #include "dmub_fw_state.h"
 #include "core_types.h"
-#include "ipp.h"
 
 #define MAX_PIPES 6
 
 /**
  * Get PSR state from firmware.
  */
-static void dmub_psr_get_state(uint32_t *psr_state)
+static void dmub_psr_get_state(struct dmub_psr *dmub, uint32_t *psr_state)
 {
-       // Not yet implemented
-       // Trigger GPINT interrupt from firmware
+       struct dmub_srv *srv = dmub->ctx->dmub_srv->dmub;
+
+       // Send gpint command and wait for ack
+       dmub_srv_send_gpint_command(srv, DMUB_GPINT__GET_PSR_STATE, 0, 30);
+
+       dmub_srv_get_gpint_response(srv, psr_state);
 }
 
 /**
@@ -100,7 +103,7 @@ static void dmub_psr_set_level(struct dmub_psr *dmub, uint16_t psr_level)
        uint32_t psr_state = 0;
        struct dc_context *dc = dmub->ctx;
 
-       dmub_psr_get_state(&psr_state);
+       dmub_psr_get_state(dmub, &psr_state);
 
        if (psr_state == 0)
                return;
index 5e8553d..3de7b94 100644 (file)
@@ -36,7 +36,7 @@ struct dmub_psr {
 struct dmub_psr_funcs {
        bool (*psr_copy_settings)(struct dmub_psr *dmub, struct dc_link *link, struct psr_context *psr_context);
        void (*psr_enable)(struct dmub_psr *dmub, bool enable);
-       void (*psr_get_state)(uint32_t *psr_state);
+       void (*psr_get_state)(struct dmub_psr *dmub, uint32_t *psr_state);
        void (*psr_set_level)(struct dmub_psr *dmub, uint16_t psr_level);
 };