iommu: Remove trivial ops->capable implementations
authorRobin Murphy <robin.murphy@arm.com>
Thu, 10 Feb 2022 12:29:05 +0000 (12:29 +0000)
committerJoerg Roedel <jroedel@suse.de>
Mon, 14 Feb 2022 13:04:38 +0000 (14:04 +0100)
Implementing ops->capable to always return false is pointless since it's
the default behaviour anyway. Clean up the unnecessary implementations.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/8413578c6f8a7cf75530b00cba8f10f5b88f8517.1644495614.git.robin.murphy@arm.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/msm_iommu.c
drivers/iommu/tegra-gart.c
drivers/iommu/tegra-smmu.c

index 3a38352..6a2e511 100644 (file)
@@ -558,11 +558,6 @@ fail:
        return ret;
 }
 
-static bool msm_iommu_capable(enum iommu_cap cap)
-{
-       return false;
-}
-
 static void print_ctx_regs(void __iomem *base, int ctx)
 {
        unsigned int fsr = GET_FSR(base, ctx);
@@ -672,7 +667,6 @@ fail:
 }
 
 static struct iommu_ops msm_iommu_ops = {
-       .capable = msm_iommu_capable,
        .domain_alloc = msm_iommu_domain_alloc,
        .domain_free = msm_iommu_domain_free,
        .attach_dev = msm_iommu_attach_dev,
index 6a358f9..bbd287d 100644 (file)
@@ -238,11 +238,6 @@ static phys_addr_t gart_iommu_iova_to_phys(struct iommu_domain *domain,
        return pte & GART_PAGE_MASK;
 }
 
-static bool gart_iommu_capable(enum iommu_cap cap)
-{
-       return false;
-}
-
 static struct iommu_device *gart_iommu_probe_device(struct device *dev)
 {
        if (!dev_iommu_fwspec_get(dev))
@@ -276,7 +271,6 @@ static void gart_iommu_sync(struct iommu_domain *domain,
 }
 
 static const struct iommu_ops gart_iommu_ops = {
-       .capable        = gart_iommu_capable,
        .domain_alloc   = gart_iommu_domain_alloc,
        .domain_free    = gart_iommu_domain_free,
        .attach_dev     = gart_iommu_attach_dev,
index e900e3c..43df44f 100644 (file)
@@ -272,11 +272,6 @@ static void tegra_smmu_free_asid(struct tegra_smmu *smmu, unsigned int id)
        clear_bit(id, smmu->asids);
 }
 
-static bool tegra_smmu_capable(enum iommu_cap cap)
-{
-       return false;
-}
-
 static struct iommu_domain *tegra_smmu_domain_alloc(unsigned type)
 {
        struct tegra_smmu_as *as;
@@ -967,7 +962,6 @@ static int tegra_smmu_of_xlate(struct device *dev,
 }
 
 static const struct iommu_ops tegra_smmu_ops = {
-       .capable = tegra_smmu_capable,
        .domain_alloc = tegra_smmu_domain_alloc,
        .domain_free = tegra_smmu_domain_free,
        .attach_dev = tegra_smmu_attach_dev,