projects / platform / upstream / gstreamer.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 625d1bf)
v4l2: object: Fix condition check to emit error
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Thu, 15 Aug 2024 20:54:25 +0000 (16:54 -0400)
committerNicolas Dufresne <nicolas@ndufresne.ca>
Tue, 24 Sep 2024 20:19:12 +0000 (20:19 +0000)
The check was reversed, so we could only emit a pipeline error
if there was no element associated with the object.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7563>

subprojects/gst-plugins-good/sys/v4l2/gstv4l2object.c patch | blob | history

diff --git a/subprojects/gst-plugins-good/sys/v4l2/gstv4l2object.c b/subprojects/gst-plugins-good/sys/v4l2/gstv4l2object.c
index e9932e3113199285bb76161e5dee50308948d99c..9b9db4165224c0e0ff29172d9c8afc75da3f4d6b 100644 (file)
--- a/subprojects/gst-plugins-good/sys/v4l2/gstv4l2object.c
+++ b/subprojects/gst-plugins-good/sys/v4l2/gstv4l2object.c
@@ -1305,7 +1305,7 @@ failed:
   {
     g_free (format);
 
-    if (v4l2object->element)
+    if (!v4l2object->element)
       return FALSE;
 
     GST_ELEMENT_ERROR (v4l2object->element, RESOURCE, SETTINGS,
Domain: Multimedia / Media Common;