drm: bridge/dw-hdmi-ahb-audio: use strscpy() is more robust and safer
authorMinghao Chi <chi.minghao@zte.com.cn>
Mon, 19 Sep 2022 03:04:01 +0000 (03:04 +0000)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 20 Sep 2022 08:59:13 +0000 (08:59 +0000)
The implementation of strscpy() is more robust and safer.

That's now the recommended way to copy NUL terminated strings.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220919030401.211331-1-chi.minghao@zte.com.cn
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c

index 7d2ed0e..4efb62b 100644 (file)
@@ -542,8 +542,8 @@ static int snd_dw_hdmi_probe(struct platform_device *pdev)
        if (ret < 0)
                return ret;
 
-       strlcpy(card->driver, DRIVER_NAME, sizeof(card->driver));
-       strlcpy(card->shortname, "DW-HDMI", sizeof(card->shortname));
+       strscpy(card->driver, DRIVER_NAME, sizeof(card->driver));
+       strscpy(card->shortname, "DW-HDMI", sizeof(card->shortname));
        snprintf(card->longname, sizeof(card->longname),
                 "%s rev 0x%02x, irq %d", card->shortname, revision,
                 data->irq);
@@ -561,7 +561,7 @@ static int snd_dw_hdmi_probe(struct platform_device *pdev)
 
        dw->pcm = pcm;
        pcm->private_data = dw;
-       strlcpy(pcm->name, DRIVER_NAME, sizeof(pcm->name));
+       strscpy(pcm->name, DRIVER_NAME, sizeof(pcm->name));
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_dw_hdmi_ops);
 
        /*