thermal/drivers/mediatek: Add delay after thermal banks initialization
authorAmjad Ouled-Ameur <aouledameur@baylibre.com>
Fri, 27 Jan 2023 15:44:46 +0000 (16:44 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Sat, 1 Apr 2023 18:51:29 +0000 (20:51 +0200)
Thermal sensor reads performed immediately after thermal bank
initialization returns bogus values. This is currently tackled by returning
0 if the temperature is bogus (exceeding 200000).

Instead, add a delay between the bank init and the thermal zone device
register to properly fix this.

Signed-off-by: Michael Kao <michael.kao@mediatek.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221018-up-i350-thermal-bringup-v9-5-55a1ae14af74@baylibre.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/thermal/mediatek/auxadc_thermal.c

index 3c959a8..b6bb9ea 100644 (file)
@@ -816,14 +816,6 @@ static int mtk_thermal_bank_temperature(struct mtk_thermal_bank *bank)
                        mt, conf->bank_data[bank->id].sensors[i], raw);
 
 
-               /*
-                * The first read of a sensor often contains very high bogus
-                * temperature value. Filter these out so that the system does
-                * not immediately shut down.
-                */
-               if (temp > 200000)
-                       temp = 0;
-
                if (temp > max)
                        max = temp;
        }
@@ -1281,6 +1273,9 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, mt);
 
+       /* Delay for thermal banks to be ready */
+       msleep(30);
+
        tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt,
                                              &mtk_thermal_ops);
        if (IS_ERR(tzdev)) {