device-manager: Don't allow setting an empty description in the client API
authorTanu Kaskinen <tanu.kaskinen@linux.intel.com>
Tue, 12 Aug 2014 09:48:22 +0000 (12:48 +0300)
committerTanu Kaskinen <tanu.kaskinen@linux.intel.com>
Sun, 24 Aug 2014 09:43:11 +0000 (12:43 +0300)
The module implementation treats an empty description as a protocol
error, so we should validate the description already at client side.

src/pulse/ext-device-manager.c

index 7fbb7de..9158068 100644 (file)
@@ -225,6 +225,7 @@ pa_operation *pa_ext_device_manager_set_device_description(
     PA_CHECK_VALIDITY_RETURN_NULL(c, !pa_detect_fork(), PA_ERR_FORKED);
     PA_CHECK_VALIDITY_RETURN_NULL(c, c->state == PA_CONTEXT_READY, PA_ERR_BADSTATE);
     PA_CHECK_VALIDITY_RETURN_NULL(c, c->version >= 14, PA_ERR_NOTSUPPORTED);
+    PA_CHECK_VALIDITY_RETURN_NULL(c, *description, PA_ERR_INVALID);
 
     o = pa_operation_new(c, NULL, (pa_operation_cb_t) cb, userdata);