fixup! [dev/m42][uBrowser]Select picker doesn't work

FrameMsg_ClosePopupMenu does not exist in chromium
and we do not need it anymore. To close a popup,
a FrameMsg_SelectPopupMenuItems message is emitted
with an empty vector as parameter passed.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12720
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: I419dc0bb7708c295e54e6a636133ad1f814b0134
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>

diff --git a/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.cc b/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.cc
index 1d8ea96..5cd0ed7 100644 (file)
--- a/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.cc
+++ b/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.cc
@@ -78,9 +78,6 @@ bool RenderFrameObserverEfl::OnMessageReceived(const IPC::Message& message) {
     IPC_MESSAGE_HANDLER(EwkFrameMsg_LoadNotFoundErrorPage, OnLoadNotFoundErrorPage)
     IPC_MESSAGE_HANDLER(FrameMsg_SelectPopupMenuItems, OnSelectPopupMenuItems)
 #if !defined(EWK_BRINGUP)
-    IPC_MESSAGE_HANDLER(FrameMsg_ClosePopupMenu, OnClosePopupMenu)
-#endif
-#if !defined(EWK_BRINGUP)
     IPC_MESSAGE_HANDLER(FrameMsg_MoveToPreviousSelectElement, OnMovePreviousSelectElement)
     IPC_MESSAGE_HANDLER(FrameMsg_MoveToNextSelectElement, OnMoveNextSelectElement)
 #endif
@@ -106,17 +103,6 @@ void RenderFrameObserverEfl::OnSelectPopupMenuItems(
     render_frame_impl_->DidHideExternalPopupMenu();
 }
 
-void RenderFrameObserverEfl::OnClosePopupMenu() {
-#if !defined(EWK_BRINGUP)
-  RenderFrameImpl* render_frame_impl_ = static_cast<RenderFrameImpl*>(render_frame());
-  ExternalPopupMenu* external_popup_menu_ = render_frame_impl_->GetExternalPopupMenu();
-  if (external_popup_menu_ == NULL)
-    return;
-  external_popup_menu_->close();
-  render_frame_impl_->DidHideExternalPopupMenu();
-#endif
-}
-
 void RenderFrameObserverEfl::OnLoadNotFoundErrorPage(std::string errorUrl) {
   blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
   blink::WebURLError error;

diff --git a/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.h b/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.h
index 23fa8a9..67f8d52 100644 (file)
--- a/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.h
+++ b/tizen_src/ewk/efl_integration/renderer/render_frame_observer_efl.h
@@ -33,7 +33,6 @@ class RenderFrameObserverEfl : public RenderFrameObserver {
  private:
   void OnSelectPopupMenuItems(bool canceled,
                               const std::vector<int>& selected_indices);
-  void OnClosePopupMenu();
 
   void OnLoadNotFoundErrorPage(std::string errorUrl);