staging: r8188eu: remove redundant variable hoffset
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Sep 2021 08:53:02 +0000 (09:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Sep 2021 06:49:53 +0000 (08:49 +0200)
Variable hoffset is being assigned values but it is never being
used. The variable is redundant and can be removed.

Acked-by: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210907085302.10672-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c

index 760ca11..8278493 100644 (file)
@@ -1128,7 +1128,7 @@ static u16 hal_EfuseGetCurrentSize_8188e(struct adapter *pAdapter, bool bPseudoT
 {
        int     bContinual = true;
        u16     efuse_addr = 0;
-       u8 hoffset = 0, hworden = 0;
+       u8 hworden = 0;
        u8 efuse_data, word_cnts = 0;
 
        if (bPseudoTest)
@@ -1141,18 +1141,15 @@ static u16 hal_EfuseGetCurrentSize_8188e(struct adapter *pAdapter, bool bPseudoT
               AVAILABLE_EFUSE_ADDR(efuse_addr)) {
                if (efuse_data != 0xFF) {
                        if ((efuse_data & 0x1F) == 0x0F) {              /* extended header */
-                               hoffset = efuse_data;
                                efuse_addr++;
                                efuse_OneByteRead(pAdapter, efuse_addr, &efuse_data, bPseudoTest);
                                if ((efuse_data & 0x0F) == 0x0F) {
                                        efuse_addr++;
                                        continue;
                                } else {
-                                       hoffset = ((hoffset & 0xE0) >> 5) | ((efuse_data & 0xF0) >> 1);
                                        hworden = efuse_data & 0x0F;
                                }
                        } else {
-                               hoffset = (efuse_data >> 4) & 0x0F;
                                hworden =  efuse_data & 0x0F;
                        }
                        word_cnts = Efuse_CalculateWordCnts(hworden);