re PR c++/33495 (Broken diagnostic: Trouble pretty-printing statement expressions)

2007-11-02  Paolo Carlini  <pcarlini@suse.de>

	PR c++/33495
	* error.c (dump_expr): Deal specially with statements.

2007-11-02  Paolo Carlini  <pcarlini@suse.de>

	PR c++/33495
	* g++.dg/other/error19.C: New.

From-SVN: r129850

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 90bea18..3a90378 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2007-11-02  Paolo Carlini  <pcarlini@suse.de>
+
+       PR c++/33495
+       * error.c (dump_expr): Deal specially with statements.
+
 2007-11-01  Jason Merrill  <jason@redhat.com>
 
        PR c++/30897

diff --git a/gcc/cp/error.c b/gcc/cp/error.c
index 031a221..49ded5e 100644 (file)
--- a/gcc/cp/error.c
+++ b/gcc/cp/error.c
@@ -1437,6 +1437,12 @@ dump_expr (tree t, int flags)
   if (t == 0)
     return;
 
+  if (STATEMENT_CLASS_P (t))
+    {
+      pp_cxx_identifier (cxx_pp, "<statement>");
+      return;
+    }
+
   switch (TREE_CODE (t))
     {
     case VAR_DECL:

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 4303ca4..900d322 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2007-11-02  Paolo Carlini  <pcarlini@suse.de>
+
+       PR c++/33495
+       * g++.dg/other/error19.C: New.
+
 2007-11-02  Eric Botcazou  <ebotcazou@libertysurf.fr>
 
        PR rtl-optimization/28062

diff --git a/gcc/testsuite/g++.dg/other/error19.C b/gcc/testsuite/g++.dg/other/error19.C
new file mode 100644 (file)
index 0000000..9389dc1
--- /dev/null
+++ b/gcc/testsuite/g++.dg/other/error19.C
@@ -0,0 +1,7 @@
+// PR c++/33495
+
+void foo()
+{
+  if (({while(true);})) // { dg-error "forbids|<statement>" }
+    ;
+}