[Build] Remove simple warnings (#4622)
authorWonYoung Choi <wy80.choi@samsung.com>
Wed, 5 Oct 2022 01:52:09 +0000 (10:52 +0900)
committerGitHub <noreply@github.com>
Wed, 5 Oct 2022 01:52:09 +0000 (10:52 +0900)
14 files changed:
build/common.props
internals/src/Tizen.Peripheral/Tizen.Peripheral/Gpio.cs
packages-microsoft-prod.deb [deleted file]
src/Tizen.NUI.Components/Controls/Slider.cs
src/Tizen.NUI.Scene3D/src/public/Controls/Model.cs
src/Tizen.NUI.Wearable/src/public/CircularPagination.cs
src/Tizen.NUI.Wearable/src/public/CircularProgress.cs
src/Tizen.NUI.Wearable/src/public/CircularSlider.cs
src/Tizen.NUI.Wearable/src/public/RecyclerView/GridRecycleLayoutManager.cs
src/Tizen.NUI.Wearable/src/public/RecyclerView/LinearRecycleLayoutManager.cs
src/Tizen.NUI.Wearable/src/public/RecyclerView/RecyclerView.cs
src/Tizen.NUI.Wearable/src/public/WearableStyle/CircularProgressStyle.cs
src/Tizen.NUI.Wearable/src/public/WearableStyle/CircularSliderStyle.cs
src/Tizen.Network.Bluetooth/Tizen.Network.Bluetooth/BluetoothGatt.cs

index d4303b270878a00a4b84f8cafbf42e3cbb9b1e1b..490685261867f732565691421fbc7b490dd06e3a 100644 (file)
@@ -7,6 +7,7 @@
     <Deterministic>True</Deterministic>
     <ProduceReferenceAssembly>True</ProduceReferenceAssembly>
     <ProduceReferenceAssemblyInOutDir>True</ProduceReferenceAssemblyInOutDir>
+    <NoWarn>$(NoWarn);CS0618;CS0809</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>
index 239769fff0d540ae0dc1b9b31e2e333576a18226..773de8b87477dade807af2a30e16a67477357c29 100644 (file)
@@ -142,10 +142,9 @@ namespace Tizen.Peripheral.Gpio
                         break;
                 }
             }
-            catch (Exception err)
+            finally
             {
                 Dispose();
-                throw;
             }
         }
 
diff --git a/packages-microsoft-prod.deb b/packages-microsoft-prod.deb
deleted file mode 100644 (file)
index 40874bc..0000000
Binary files a/packages-microsoft-prod.deb and /dev/null differ
index 4374902387f6d52871a48adc6963b8b763b447cc..cfc3b512f9aa6061feff84824f102e4ffe9db81e 100755 (executable)
@@ -191,9 +191,10 @@ namespace Tizen.NUI.Components
                         instance.curValue = value;
                     }
 
-                    instance.sliderValueChangedHandler?.Invoke(instance, new SliderValueChangedEventArgs {
+                    instance.sliderValueChangedHandler?.Invoke(instance, new SliderValueChangedEventArgs
+                    {
                         CurrentValue = instance.curValue
-                        });
+                    });
                     if (Accessibility.Accessibility.IsEnabled && instance.IsHighlighted)
                     {
                         instance.EmitAccessibilityEvent(AccessibilityPropertyChangeEvent.Value);
@@ -1474,8 +1475,8 @@ namespace Tizen.NUI.Components
                 }
                 else
                 {
-                    /// TODO : Currently we set the velocity of value as 1% hardly.
-                    /// Can we use AccessibilityGetMinimumIncrement?
+                    // TODO : Currently we set the velocity of value as 1% hardly.
+                    // Can we use AccessibilityGetMinimumIncrement?
                     valueDiff = (maxValue - minValue) * 0.01f;
                 }
                 if ((direction == DirectionType.Horizontal && key.KeyPressedName == "Left") ||
@@ -1784,9 +1785,10 @@ namespace Tizen.NUI.Components
 
                 UpdateState(isFocused, true);
 
-                sliderSlidingStartedHandler?.Invoke(this, new SliderSlidingStartedEventArgs {
+                sliderSlidingStartedHandler?.Invoke(this, new SliderSlidingStartedEventArgs
+                {
                     CurrentValue = curValue
-                    });
+                });
 
                 Vector2 pos = e.Touch.GetLocalPosition(0);
                 CalculateCurrentValueByTouch(pos);
@@ -1801,9 +1803,10 @@ namespace Tizen.NUI.Components
 
                 UpdateState(isFocused, false);
 
-                sliderSlidingFinishedHandler?.Invoke(this, new SliderSlidingFinishedEventArgs {
+                sliderSlidingFinishedHandler?.Invoke(this, new SliderSlidingFinishedEventArgs
+                {
                     CurrentValue = curValue
-                    });
+                });
             }
             return false;
         }
index 413a05fcbd2ef903e363a47ba1623b94bf3c2e3c..1dc06c25185a1e5d46dadac7e338c01899cabfc9 100755 (executable)
@@ -148,6 +148,7 @@ namespace Tizen.NUI.Scene3D
             }
         }
 
+        /// <summary>
         /// Set/Get the ImageBasedLight ScaleFactor.
         /// Scale factor controls light source intensity in [0.0f, 1.0f]
         /// </summary>
index 4c9158bf69e244bbfc9846821d51e3d23e2891c4..4c4116260cdb812477e6d57298dd02e99924afc4 100755 (executable)
@@ -29,7 +29,7 @@ namespace Tizen.NUI.Wearable
     /// <since_tizen> 8 </since_tizen>
     /// This will be public opened in tizen_6.0 after ACR done. Before ACR, need to be hidden as inhouse API.
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public class CircularPagination: Control
+    public class CircularPagination : Control
     {
         private CircularPaginationStyle circularPaginationStyle;
 
@@ -254,7 +254,7 @@ namespace Tizen.NUI.Wearable
 
                     for (int i = (indicatorCount + 1); i <= value; i++)
                     {
-                        CreateIndicator( arrayIndex );
+                        CreateIndicator(arrayIndex);
                         arrayIndex++;
                     }
 
@@ -320,7 +320,7 @@ namespace Tizen.NUI.Wearable
                 {
                     for (int i = (middleIndex - value); i < (middleIndex - leftIndicatorCount); i++)
                     {
-                        CreateIndicator( i );
+                        CreateIndicator(i);
                         selectedIndex++;
                     }
                 }
@@ -392,7 +392,7 @@ namespace Tizen.NUI.Wearable
                 {
                     for (int i = (middleIndex + rightIndicatorCount + 1); i <= (middleIndex + value); i++)
                     {
-                        CreateIndicator( i );
+                        CreateIndicator(i);
                     }
                 }
                 else
@@ -443,8 +443,8 @@ namespace Tizen.NUI.Wearable
 
                 if (selectedIndex >= 0)
                 {
-                    if ( (isSymmetrical && selectedIndex < indicatorCount) ||
-                         (!isSymmetrical && selectedIndex <= (middleIndex + rightIndicatorCount) ) )
+                    if ((isSymmetrical && selectedIndex < indicatorCount) ||
+                         (!isSymmetrical && selectedIndex <= (middleIndex + rightIndicatorCount)))
                     {
                         CheckCenterIndicator(selectedIndex);
                         SelectOut(indicatorList[selectedIndex]);
@@ -453,8 +453,8 @@ namespace Tizen.NUI.Wearable
                 selectedIndex = value;
                 if (selectedIndex >= 0)
                 {
-                    if ( (isSymmetrical && selectedIndex < indicatorCount) ||
-                         (!isSymmetrical && selectedIndex <= (middleIndex + rightIndicatorCount) ) )
+                    if ((isSymmetrical && selectedIndex < indicatorCount) ||
+                         (!isSymmetrical && selectedIndex <= (middleIndex + rightIndicatorCount)))
                     {
                         CheckCenterIndicator(selectedIndex);
                         SelectIn(indicatorList[selectedIndex]);
@@ -664,9 +664,9 @@ namespace Tizen.NUI.Wearable
         {
             if (isCenterImageSet &&
                 (isSymmetrical && (index == indicatorCount / 2)) ||
-                (!isSymmetrical && (index == leftIndicatorCount)) )
+                (!isSymmetrical && (index == leftIndicatorCount)))
             {
-                isCurrentIndicatorCentered  = true;
+                isCurrentIndicatorCentered = true;
             }
             else
             {
@@ -780,7 +780,7 @@ namespace Tizen.NUI.Wearable
                 {
                     newOne.URL = circularPaginationStyle.IndicatorImageURL.Normal;
                 }
-                newOne.Opacity  = 0.5f;
+                newOne.Opacity = 0.5f;
                 container.AddVisual("Indicator" + i, newOne);
                 indicatorList.Add(newOne);
             }
index f996e479e477402fd8f2199a4a66a3753b1b39c9..eef7387165352126f3b6fbed540589b32a7132e0 100755 (executable)
@@ -127,7 +127,7 @@ namespace Tizen.NUI.Wearable
 
         /// <summary>Bindable property of IsEnabled</summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool), typeof(CircularProgress), true, propertyChanged: (bindable, oldValue, newValue) =>
+        public new static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool), typeof(CircularProgress), true, propertyChanged: (bindable, oldValue, newValue) =>
         {
             var instance = (CircularProgress)bindable;
             if (newValue != null)
@@ -311,7 +311,7 @@ namespace Tizen.NUI.Wearable
         /// Flag to be enabled or disabled in CircularProgress.
         /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public bool IsEnabled
+        public new bool IsEnabled
         {
             get
             {
index eeb5eeb20ff22fcdcb212304b1abb1f56fcb42de..b9b62379cc4420baee136d183f5b02f45b01715e 100755 (executable)
@@ -146,7 +146,7 @@ namespace Tizen.NUI.Wearable
 
         /// <summary>Bindable property of ThumbSize</summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public static readonly BindableProperty ThumbSizeProperty = BindableProperty.Create(nameof(ThumbSize), typeof(Size), typeof(CircularSlider), new Size(0,0), propertyChanged: (bindable, oldValue, newValue) =>
+        public static readonly BindableProperty ThumbSizeProperty = BindableProperty.Create(nameof(ThumbSize), typeof(Size), typeof(CircularSlider), new Size(0, 0), propertyChanged: (bindable, oldValue, newValue) =>
         {
             var instance = (CircularSlider)bindable;
             if (newValue != null)
@@ -176,7 +176,7 @@ namespace Tizen.NUI.Wearable
 
         /// <summary>Bindable property of IsEnabled</summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool), typeof(CircularSlider), true, propertyChanged: (bindable, oldValue, newValue) =>
+        public new static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool), typeof(CircularSlider), true, propertyChanged: (bindable, oldValue, newValue) =>
         {
             var instance = (CircularSlider)bindable;
             if (newValue != null)
@@ -395,7 +395,7 @@ namespace Tizen.NUI.Wearable
         /// Flag to be enabled or disabled in CircularSlider.
         /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public bool IsEnabled
+        public new bool IsEnabled
         {
             get
             {
@@ -533,7 +533,7 @@ namespace Tizen.NUI.Wearable
                 StartAngle = 0.0f,
                 SweepAngle = 0.0f
             };
-            this.AddVisual(ThumbVisualName,  thumbVisual);
+            this.AddVisual(ThumbVisualName, thumbVisual);
 
             HandleProgressVisualVisibility();
 
index 85224e1ed12a9c2acb72e3ce12517719ce433f88..9d1b762ee874c5c0a931219e23b51745deace53c 100755 (executable)
@@ -260,6 +260,7 @@ namespace Tizen.NUI.Wearable
             return scrollPosition;
         }
 
+        /// <inheritdoc/>
         public override View RequestNextFocusableView(View currentFocusedView, View.FocusDirection direction, bool loopEnabled)
         {
             View nextFocusedView = null;
index 55860c50d5be91cbee255b33b29bb18642027383..4f8573edb2353c51f81442d78093b8dfeece7c9d 100755 (executable)
@@ -187,6 +187,7 @@ namespace Tizen.NUI.Wearable
             return scrollPosition;
         }
 
+        /// <inheritdoc/>
         public override View RequestNextFocusableView(View currentFocusedView, View.FocusDirection direction, bool loopEnabled)
         {
             View nextFocusedView = null;
index 903d9d3bdce8007f1da75f5681baa353e5bdd590..606225edee83d91e7c2d801c5a23a80c9c3b3b50 100755 (executable)
@@ -33,13 +33,16 @@ namespace Tizen.NUI.Wearable
         private int totalItemCount = 15;
         private List<PropertyNotification> notifications = new List<PropertyNotification>();
 
+        /// <summary>
+        /// Default constructor.
+        /// </summary>
         public RecyclerView() : base()
         {
             Initialize(new RecycleAdapter(), new RecycleLayoutManager());
         }
 
         /// <summary>
-        /// Default constructor.
+        /// A constructor of <see cref="RecyclerView" />.
         /// </summary>
         /// <param name="adapter">Recycle adapter of RecyclerView.</param>
         /// <param name="layoutManager">Recycle layoutManager of RecyclerView.</param>
index 4bfa081a130ca6570c331a1d1d7fdf47e2b60ea2..5b068722e2601ee85cd6ab6753377d58ecb67964 100755 (executable)
@@ -95,7 +95,7 @@ namespace Tizen.NUI.Wearable
 
         /// <summary>Bindable property of IsEnabled</summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool?), typeof(CircularProgressStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
+        public new static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool?), typeof(CircularProgressStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
         {
             ((CircularProgressStyle)bindable).isEnabled = (bool?)newValue;
         },
@@ -232,7 +232,7 @@ namespace Tizen.NUI.Wearable
         /// Flag to be enabled or disabled in CircularProgress.
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
-        public bool? IsEnabled
+        public new bool? IsEnabled
         {
             get
             {
index eae2cc6f21e2b4a2c679cc538094abab1df425a1..119bd88ae6de651de9b456d46746ce16d83b4644 100755 (executable)
@@ -95,7 +95,7 @@ namespace Tizen.NUI.Wearable
 
         /// <summary>Bindable property of ThumbSize</summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public static readonly BindableProperty ThumbSizeProperty = BindableProperty.Create(nameof(ThumbSize), typeof(Size), typeof(CircularSliderStyle), new Size(0,0), propertyChanged: (bindable, oldValue, newValue) =>
+        public static readonly BindableProperty ThumbSizeProperty = BindableProperty.Create(nameof(ThumbSize), typeof(Size), typeof(CircularSliderStyle), new Size(0, 0), propertyChanged: (bindable, oldValue, newValue) =>
         {
             ((CircularSliderStyle)bindable).thumbSize = (Size)newValue;
         },
@@ -117,7 +117,7 @@ namespace Tizen.NUI.Wearable
 
         /// <summary>Bindable property of IsEnabled</summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool?), typeof(CircularSliderStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
+        public new static readonly BindableProperty IsEnabledProperty = BindableProperty.Create(nameof(IsEnabled), typeof(bool?), typeof(CircularSliderStyle), null, propertyChanged: (bindable, oldValue, newValue) =>
         {
             ((CircularSliderStyle)bindable).isEnabled = (bool?)newValue;
         },
@@ -288,7 +288,7 @@ namespace Tizen.NUI.Wearable
         /// Flag to be enabled or disabled in CircularSlider.
         /// </summary>
         /// <since_tizen> 8 </since_tizen>
-        public bool? IsEnabled
+        public new bool? IsEnabled
         {
             get
             {
index bb98c01d45ccb1c3153017449cbc775f0c0ff09d..5eb7b0ab64c2e89404b8c7fd5caceae8da901f44 100644 (file)
@@ -231,6 +231,7 @@ namespace Tizen.Network.Bluetooth
             return _impl.GetAttMtu(clientAddress);
         }
 
+        /// <summary>
         /// The AttMtuChanged event is raised when the MTU value changed.
         /// </summary>
         /// <since_tizen> 9 </since_tizen>
@@ -1056,7 +1057,7 @@ namespace Tizen.Network.Bluetooth
                 _parent = parent;
                 ReleaseHandleOwnership();
             }
-         }
+        }
     }
 
     /// <summary>
@@ -1077,7 +1078,7 @@ namespace Tizen.Network.Bluetooth
         /// <remarks>throws in case of internal error.</remarks>
         /// <exception cref="InvalidOperationException">Thrown when the create GATT descriptor procedure fails.</exception>
         /// <since_tizen> 3 </since_tizen>
-        public BluetoothGattDescriptor(string uuid, BluetoothGattPermission permisions, byte[] value) : base (uuid, permisions)
+        public BluetoothGattDescriptor(string uuid, BluetoothGattPermission permisions, byte[] value) : base(uuid, permisions)
         {
             _impl = new BluetoothGattDescriptorImpl(uuid, permisions, value);
         }