PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR and PTR_ERR
authorYueHaibing <yuehaibing@huawei.com>
Mon, 30 Dec 2019 08:47:31 +0000 (16:47 +0800)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 30 Dec 2019 18:09:57 +0000 (03:09 +0900)
Fix inconsistent IS_ERR and PTR_ERR in imx8m_ddrc_probe().
Detected using Coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/imx8m-ddrc.c

index 53df792..bc82d36 100644 (file)
@@ -395,15 +395,27 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
        }
 
        priv->dram_core = devm_clk_get(dev, "core");
+       if (IS_ERR(priv->dram_core)) {
+               ret = PTR_ERR(priv->dram_core);
+               dev_err(dev, "failed to fetch core clock: %d\n", ret);
+               return ret;
+       }
        priv->dram_pll = devm_clk_get(dev, "pll");
+       if (IS_ERR(priv->dram_pll)) {
+               ret = PTR_ERR(priv->dram_pll);
+               dev_err(dev, "failed to fetch pll clock: %d\n", ret);
+               return ret;
+       }
        priv->dram_alt = devm_clk_get(dev, "alt");
+       if (IS_ERR(priv->dram_alt)) {
+               ret = PTR_ERR(priv->dram_alt);
+               dev_err(dev, "failed to fetch alt clock: %d\n", ret);
+               return ret;
+       }
        priv->dram_apb = devm_clk_get(dev, "apb");
-       if (IS_ERR(priv->dram_core) ||
-               IS_ERR(priv->dram_pll) ||
-               IS_ERR(priv->dram_alt) ||
-               IS_ERR(priv->dram_apb)) {
-               ret = PTR_ERR(priv->devfreq);
-               dev_err(dev, "failed to fetch clocks: %d\n", ret);
+       if (IS_ERR(priv->dram_apb)) {
+               ret = PTR_ERR(priv->dram_apb);
+               dev_err(dev, "failed to fetch apb clock: %d\n", ret);
                return ret;
        }