Remove Perl_mod

After mod was renamed to op_lvalue, this stub was added temporarily
to provide a smoother transition for the compilers.  The compiler
maintainer is happy with its extirpation at this stage.  See
ticket #78908.

diff --git a/embed.fnc b/embed.fnc
index a84a95861910015bc1a90233defb33faccbe3bd1..f48d8ce9c7cabf0fad40c756524608b0d7ada77f 100644 (file)
--- a/embed.fnc
+++ b/embed.fnc
@@ -758,8 +758,6 @@ Ap  |I32    |mg_size        |NN SV* sv
 Ap     |void   |mini_mktime    |NN struct tm *ptm
 AMmd   |OP*    |op_lvalue      |NULLOK OP* o|I32 type
 poX    |OP*    |op_lvalue_flags|NULLOK OP* o|I32 type|U32 flags
-: To be removed after 5.14 (see [perl #78908]):
-EXp    |OP*    |mod            |NULLOK OP* o|I32 type
 p      |void   |finalize_optree                |NN OP* o
 #if defined(PERL_IN_OP_C)
 s      |void   |finalize_op    |NN OP* o

diff --git a/embed.h b/embed.h
index b15a92e41708b01db1e097ed6afa2ec63ad8b248..0b3c4dca577ef1cce299632ace7fe455d0253feb 100644 (file)
--- a/embed.h
+++ b/embed.h
@@ -840,7 +840,6 @@
 #define is_utf8_X_extend(a)    Perl_is_utf8_X_extend(aTHX_ a)
 #define is_utf8_X_non_hangul(a)        Perl_is_utf8_X_non_hangul(aTHX_ a)
 #define is_utf8_X_prepend(a)   Perl_is_utf8_X_prepend(aTHX_ a)
-#define mod(a,b)               Perl_mod(aTHX_ a,b)
 #define op_clear(a)            Perl_op_clear(aTHX_ a)
 #define qerror(a)              Perl_qerror(aTHX_ a)
 #define reg_named_buff(a,b,c,d)        Perl_reg_named_buff(aTHX_ a,b,c,d)

diff --git a/global.sym b/global.sym
index 11de51ef9c27d606b502bfa797e81440e052b73e..0a27f2982f58aabc04c7d8ad1eb2b87260789839 100644 (file)
--- a/global.sym
+++ b/global.sym
@@ -323,7 +323,6 @@ Perl_mg_magical
 Perl_mg_set
 Perl_mg_size
 Perl_mini_mktime
-Perl_mod
 Perl_moreswitches
 Perl_mro_get_from_name
 Perl_mro_get_linear_isa

diff --git a/op.c b/op.c
index 68aa1a7b1da79a994a25b72220f6e8648dc8f69b..c9b4d519a6c19b05501966f3b19e79b41850a95a 100644 (file)
--- a/op.c
+++ b/op.c
@@ -2011,14 +2011,6 @@ Perl_op_lvalue_flags(pTHX_ OP *o, I32 type, U32 flags)
     return o;
 }
 
-/* Do not use this. It will be removed after 5.14. */
-OP *
-Perl_mod(pTHX_ OP *o, I32 type)
-{
-    return op_lvalue(o,type);
-}
-
-
 STATIC bool
 S_scalar_mod_type(const OP *o, I32 type)
 {

diff --git a/proto.h b/proto.h
index 6ddc11c7b912b43592717f1b69147f35c8372b17..2c63536ebcb858f38aaa05e42cb4c6a87ed63a55 100644 (file)
--- a/proto.h
+++ b/proto.h
@@ -2282,7 +2282,6 @@ PERL_CALLCONV void        Perl_mini_mktime(pTHX_ struct tm *ptm)
 #define PERL_ARGS_ASSERT_MINI_MKTIME   \
        assert(ptm)
 
-PERL_CALLCONV OP*      Perl_mod(pTHX_ OP* o, I32 type);
 PERL_CALLCONV int      Perl_mode_from_discipline(pTHX_ const char* s, STRLEN len);
 PERL_CALLCONV void *   Perl_more_bodies(pTHX_ const svtype sv_type, const size_t body_size, const size_t arena_size);
 PERL_CALLCONV const char*      Perl_moreswitches(pTHX_ const char* s)