oss4: fix a missing unlock and a return-only-when-assertions-enabled

Spotted on the side while looking at another issue.

diff --git a/sys/oss4/oss4-property-probe.c b/sys/oss4/oss4-property-probe.c
index 2e164f2853506431f7ba7b5a2461aa60f5e7658e..51ff3c1ca9f9b3c0ea5b76e8e1e25cefb47f2595 100644 (file)
--- a/sys/oss4/oss4-property-probe.c
+++ b/sys/oss4/oss4-property-probe.c
@@ -315,7 +315,8 @@ gst_oss4_property_probe_get_values (GstObject * probe, const gchar * pname)
     fd = GST_OSS4_SOURCE (probe)->fd;
   } else {
     GST_OBJECT_UNLOCK (obj);
-    g_return_val_if_reached (NULL);
+    g_assert_not_reached ();
+    return NULL;
   }
 
   /* copy fd if it's open, so we can just unconditionally close() later */
@@ -342,6 +343,7 @@ gst_oss4_property_probe_get_values (GstObject * probe, const gchar * pname)
   }
 
   if (devices == NULL) {
+    GST_OBJECT_UNLOCK (obj);
     GST_DEBUG_OBJECT (obj, "No devices found");
     goto done;
   }