sh: hw-breakpoints: Accept breakpoints on NULL addresses.
authorPaul Mundt <lethal@linux-sh.org>
Mon, 1 Mar 2010 02:52:03 +0000 (11:52 +0900)
committerPaul Mundt <lethal@linux-sh.org>
Mon, 1 Mar 2010 02:52:03 +0000 (11:52 +0900)
This follows the x86 change 84d710926797a6e317e7e94654a3ccd771cfd8a3
("hw-breakpoints: Accept breakpoints on NULL address") and restores the
previous expected ptrace behaviour.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
arch/sh/kernel/hw_breakpoint.c

index e2f1753..675eea7 100644 (file)
@@ -143,26 +143,6 @@ static int arch_check_va_in_kernelspace(unsigned long va, u8 hbp_len)
        return (va >= TASK_SIZE) && ((va + len - 1) >= TASK_SIZE);
 }
 
-/*
- * Store a breakpoint's encoded address, length, and type.
- */
-static int arch_store_info(struct perf_event *bp)
-{
-       struct arch_hw_breakpoint *info = counter_arch_bp(bp);
-
-       /*
-        * User-space requests will always have the address field populated
-        * For kernel-addresses, either the address or symbol name can be
-        * specified.
-        */
-       if (info->name)
-               info->address = (unsigned long)kallsyms_lookup_name(info->name);
-       if (info->address)
-               return 0;
-
-       return -EINVAL;
-}
-
 int arch_bp_generic_fields(int sh_len, int sh_type,
                           int *gen_len, int *gen_type)
 {
@@ -276,10 +256,12 @@ int arch_validate_hwbkpt_settings(struct perf_event *bp,
                return ret;
        }
 
-       ret = arch_store_info(bp);
-
-       if (ret < 0)
-               return ret;
+       /*
+        * For kernel-addresses, either the address or symbol name can be
+        * specified.
+        */
+       if (info->name)
+               info->address = (unsigned long)kallsyms_lookup_name(info->name);
 
        /*
         * Check that the low-order bits of the address are appropriate