Reimplement QVariantAnimation::updateState() properly
authorBradley T. Hughes <bradley.hughes@nokia.com>
Tue, 20 Dec 2011 08:22:20 +0000 (09:22 +0100)
committerQt by Nokia <qt-info@nokia.com>
Wed, 21 Dec 2011 19:32:31 +0000 (20:32 +0100)
The updateState() takes 2 arguments, not 1.

tests/benchmarks/gui/animation/qanimation/dummyanimation.h:54: warning:
'DummyAnimation::updateState' hides overloaded virtual function
[-Woverloaded-virtual]
    void updateState(State state);
         ^
src/corelib/animation/qvariantanimation.h:106: hidden overloaded virtual
function 'QVariantAnimation::updateState' declared here
    void updateState(QAbstractAnimation::State newState, QAbstractAnimation::State oldState);
         ^

Change-Id: Ieb2e4e0b1f017c51c4fed5bdb874ba30cb056916
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
tests/benchmarks/gui/animation/qanimation/dummyanimation.cpp
tests/benchmarks/gui/animation/qanimation/dummyanimation.h

index a190a03..fa0c8d1 100644 (file)
@@ -55,7 +55,8 @@ void DummyAnimation::updateCurrentValue(const QVariant &value)
         m_dummy->setRect(value.toRect());
 }
 
-void DummyAnimation::updateState(State state)
+void DummyAnimation::updateState(State newstate, State oldstate)
 {
-    Q_UNUSED(state);
+    Q_UNUSED(newstate);
+    Q_UNUSED(oldstate);
 }
index ecd4e01..87fe6d2 100644 (file)
@@ -51,7 +51,7 @@ public:
     DummyAnimation(DummyObject *d);
 
     void updateCurrentValue(const QVariant &value);
-    void updateState(State state);
+    void updateState(State newstate, State oldstate);
 
 private:
     DummyObject *m_dummy;