ice: remove redundant assignment to variable xmit_done
authorColin Ian King <colin.king@canonical.com>
Thu, 19 Dec 2019 23:45:35 +0000 (23:45 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 17 Jan 2020 17:55:34 +0000 (09:55 -0800)
The variable xmit_done is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_xsk.c

index 0e401f1..149dca0 100644 (file)
@@ -1020,8 +1020,8 @@ bool ice_clean_tx_irq_zc(struct ice_ring *xdp_ring, int budget)
        s16 ntc = xdp_ring->next_to_clean;
        struct ice_tx_desc *tx_desc;
        struct ice_tx_buf *tx_buf;
-       bool xmit_done = true;
        u32 xsk_frames = 0;
+       bool xmit_done;
 
        tx_desc = ICE_TX_DESC(xdp_ring, ntc);
        tx_buf = &xdp_ring->tx_buf[ntc];