crypto: ux500/hash - simplify if-if to if-else
authorYihao Han <hanyihao@vivo.com>
Fri, 8 Apr 2022 14:23:49 +0000 (07:23 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Apr 2022 08:34:28 +0000 (16:34 +0800)
Replace `if (!req_ctx->updated)` with `else` for simplification
and add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Signed-off-by: Yihao Han <hanyihao@vivo.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ux500/hash/hash_core.c

index 5157c11..265ef3e 100644 (file)
@@ -877,9 +877,7 @@ static int hash_dma_final(struct ahash_request *req)
                                __func__);
                        goto out;
                }
-       }
-
-       if (!req_ctx->updated) {
+       } else {
                ret = hash_setconfiguration(device_data, &ctx->config);
                if (ret) {
                        dev_err(device_data->dev,