usb: musb: Fix missing of_node_put() in omap2430_probe
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 9 Mar 2022 11:10:33 +0000 (11:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:36:04 +0000 (18:36 +0200)
[ Upstream commit 424bef51fa530389b0b9008c9e144e40c10e8458 ]

The device_node pointer is returned by of_parse_phandle() with refcount
incremented. We should use of_node_put() on it when done.

Fixes: 8934d3e4d0e7 ("usb: musb: omap2430: Don't use omap_get_control_dev()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220309111033.24487-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/musb/omap2430.c

index f086960..bd1de5c 100644 (file)
@@ -363,6 +363,7 @@ static int omap2430_probe(struct platform_device *pdev)
        control_node = of_parse_phandle(np, "ctrl-module", 0);
        if (control_node) {
                control_pdev = of_find_device_by_node(control_node);
+               of_node_put(control_node);
                if (!control_pdev) {
                        dev_err(&pdev->dev, "Failed to get control device\n");
                        ret = -EINVAL;