pvr: Zero init pbe_cs_words to avoid passing on garbage.
authorRajnesh Kanwal <rajnesh.kanwal@imgtec.com>
Sun, 25 Sep 2022 18:52:10 +0000 (19:52 +0100)
committerMarge Bot <emma+marge@anholt.net>
Fri, 30 Sep 2022 10:52:51 +0000 (10:52 +0000)
In case if the surface->resolve_type is not PVR_RESOLVE_TYPE_PBE
then we do not setup pbe_cs_words in which case we might end up
using garbage values.

Fixes: CID 1515466.

Signed-off-by: Rajnesh Kanwal <rajnesh.kanwal@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18866>

src/imagination/vulkan/pvr_cmd_buffer.c

index ebedde9..0b330a1 100644 (file)
@@ -916,9 +916,8 @@ static VkResult pvr_sub_cmd_gfx_job_init(const struct pvr_device_info *dev_info,
       &render_pass_info->pass->hw_setup->renders[sub_cmd->hw_render_idx];
    struct pvr_render_job *job = &sub_cmd->job;
    struct pvr_pds_upload pds_pixel_event_program;
-
    uint32_t pbe_cs_words[PVR_MAX_COLOR_ATTACHMENTS]
-                        [ROGUE_NUM_PBESTATE_STATE_WORDS];
+                        [ROGUE_NUM_PBESTATE_STATE_WORDS] = { 0 };
    struct pvr_render_target *render_target;
    VkResult result;