usb: reduce kernel log spam on driver registration
authorArd Biesheuvel <ardb@kernel.org>
Thu, 25 Aug 2022 17:03:27 +0000 (19:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Aug 2022 07:07:53 +0000 (09:07 +0200)
Drivers are typically supposed to be quiet unless they are actually
probed, but for some reason, USB host controllers seem to be exempt from
this rule, and happily broadcast their existence into the kernel log at
boot even if the hardware in question is nowhere to be found.

Let's fix that, and remove these pr_info() calls.

Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avi Fishman <avifishman70@gmail.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>
Cc: Tali Perry <tali.perry1@gmail.com>
Cc: Patrick Venture <venture@google.com>
Cc: Nancy Yuen <yuenn@google.com>
Cc: Benjamin Fair <benjaminfair@google.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Vladimir Zapolskiy <vz@mleia.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20220825170327.674446-1-ardb@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
24 files changed:
drivers/usb/host/ehci-atmel.c
drivers/usb/host/ehci-exynos.c
drivers/usb/host/ehci-fsl.c
drivers/usb/host/ehci-hcd.c
drivers/usb/host/ehci-npcm7xx.c
drivers/usb/host/ehci-omap.c
drivers/usb/host/ehci-orion.c
drivers/usb/host/ehci-pci.c
drivers/usb/host/ehci-platform.c
drivers/usb/host/ehci-spear.c
drivers/usb/host/ehci-st.c
drivers/usb/host/fotg210-hcd.c
drivers/usb/host/ohci-at91.c
drivers/usb/host/ohci-da8xx.c
drivers/usb/host/ohci-exynos.c
drivers/usb/host/ohci-hcd.c
drivers/usb/host/ohci-nxp.c
drivers/usb/host/ohci-omap.c
drivers/usb/host/ohci-pci.c
drivers/usb/host/ohci-platform.c
drivers/usb/host/ohci-pxa27x.c
drivers/usb/host/ohci-s3c2410.c
drivers/usb/host/ohci-spear.c
drivers/usb/host/ohci-st.c

index 05d41fd..0e99501 100644 (file)
@@ -239,7 +239,6 @@ static int __init ehci_atmel_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
        ehci_init_driver(&ehci_atmel_hc_driver, &ehci_atmel_drv_overrides);
        return platform_driver_register(&ehci_atmel_driver);
 }
index 1a9b757..a65e365 100644 (file)
@@ -347,7 +347,6 @@ static int __init ehci_exynos_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
        ehci_init_driver(&exynos_ehci_hc_driver, &exynos_overrides);
        return platform_driver_register(&exynos_ehci_driver);
 }
index 896c0d1..9cea785 100644 (file)
@@ -722,8 +722,6 @@ static int __init ehci_fsl_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info(DRV_NAME ": " DRIVER_DESC "\n");
-
        ehci_init_driver(&fsl_ehci_hc_driver, &ehci_fsl_overrides);
 
        fsl_ehci_hc_driver.product_desc =
index 684164f..a1930db 100644 (file)
@@ -1351,7 +1351,6 @@ static int __init ehci_hcd_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name);
        set_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
        if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) ||
                        test_bit(USB_OHCI_LOADED, &usb_hcds_loaded))
index 1d2e2c3..f4060b3 100644 (file)
@@ -141,8 +141,6 @@ static int __init ehci_npcm7xx_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_npcm7xx_hc_driver, NULL);
        return platform_driver_register(&npcm7xx_ehci_hcd_driver);
 }
index 8c45bc1..7dd9847 100644 (file)
@@ -284,8 +284,6 @@ static int __init ehci_omap_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_omap_hc_driver, &ehci_omap_overrides);
        return platform_driver_register(&ehci_hcd_omap_driver);
 }
index 3626758..2c8b1e6 100644 (file)
@@ -361,8 +361,6 @@ static int __init ehci_orion_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_orion_hc_driver, &orion_overrides);
        return platform_driver_register(&ehci_orion_driver);
 }
index 9937c5a..9581952 100644 (file)
@@ -423,8 +423,6 @@ static int __init ehci_pci_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_pci_hc_driver, &pci_overrides);
 
        /* Entries for the PCI suspend/resume callbacks are special */
index 6924f03..50491ee 100644 (file)
@@ -529,8 +529,6 @@ static int __init ehci_platform_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides);
        return platform_driver_register(&ehci_platform_driver);
 }
index 3694e45..1336928 100644 (file)
@@ -167,8 +167,6 @@ static int __init ehci_spear_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_spear_hc_driver, &spear_overrides);
        return platform_driver_register(&spear_ehci_hcd_driver);
 }
index f74433a..1086078 100644 (file)
@@ -346,8 +346,6 @@ static int __init ehci_platform_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides);
        return platform_driver_register(&ehci_platform_driver);
 }
index f8c111e..3d1dbcf 100644 (file)
@@ -5692,7 +5692,6 @@ static int __init fotg210_hcd_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
        set_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
        if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) ||
                        test_bit(USB_OHCI_LOADED, &usb_hcds_loaded))
index 9832646..adf0998 100644 (file)
@@ -699,7 +699,6 @@ static int __init ohci_at91_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
        ohci_init_driver(&ohci_at91_hc_driver, &ohci_at91_drv_overrides);
 
        /*
index 1371b0c..d4818e8 100644 (file)
@@ -551,7 +551,6 @@ static int __init ohci_da8xx_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", DRV_NAME);
        ohci_init_driver(&ohci_da8xx_hc_driver, &da8xx_overrides);
 
        /*
index 5f5e8a6..a060be6 100644 (file)
@@ -310,7 +310,6 @@ static int __init ohci_exynos_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
        ohci_init_driver(&exynos_ohci_hc_driver, &exynos_overrides);
        return platform_driver_register(&exynos_ohci_driver);
 }
index c4c821c..0457dd9 100644 (file)
@@ -1276,7 +1276,6 @@ static int __init ohci_hcd_mod_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name);
        pr_debug ("%s: block sizes: ed %zd td %zd\n", hcd_name,
                sizeof (struct ed), sizeof (struct td));
        set_bit(USB_OHCI_LOADED, &usb_hcds_loaded);
index 106a6bc..5b32e68 100644 (file)
@@ -275,8 +275,6 @@ static int __init ohci_nxp_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_nxp_hc_driver, NULL);
        return platform_driver_register(&ohci_hcd_nxp_driver);
 }
index f5bc9c8..cb29701 100644 (file)
@@ -423,8 +423,6 @@ static int __init ohci_omap_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_omap_hc_driver, &omap_overrides);
        return platform_driver_register(&ohci_hcd_omap_driver);
 }
index 41efe92..a146b2d 100644 (file)
@@ -306,8 +306,6 @@ static int __init ohci_pci_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_pci_hc_driver, &pci_overrides);
 
 #ifdef CONFIG_PM
index 0adae62..6d56b52 100644 (file)
@@ -346,8 +346,6 @@ static int __init ohci_platform_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides);
        return platform_driver_register(&ohci_platform_driver);
 }
index ab4f610..f2504b8 100644 (file)
@@ -608,8 +608,6 @@ static int __init ohci_pxa27x_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_pxa27x_hc_driver, &pxa27x_overrides);
        ohci_pxa27x_hc_driver.hub_control = pxa27x_ohci_hub_control;
 
index 12264c0..7207c7a 100644 (file)
@@ -474,7 +474,6 @@ static int __init ohci_s3c2410_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
        ohci_init_driver(&ohci_s3c2410_hc_driver, NULL);
 
        /*
index 9b81f42..71a3f18 100644 (file)
@@ -179,8 +179,6 @@ static int __init ohci_spear_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_spear_hc_driver, &spear_overrides);
        return platform_driver_register(&spear_ohci_hcd_driver);
 }
index ac796cc..2e542a3 100644 (file)
@@ -324,8 +324,6 @@ static int __init ohci_platform_init(void)
        if (usb_disabled())
                return -ENODEV;
 
-       pr_info("%s: " DRIVER_DESC "\n", hcd_name);
-
        ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides);
        return platform_driver_register(&ohci_platform_driver);
 }