scsi: ufs: ufshpb: Do not report victim error in HCM

In host control mode, eviction is perceived as an extreme measure. There
are several conditions that both the entering and exiting regions should
meet, so that eviction will take place.

The common case however, is that those conditions are rarely met, so it is
normal that the act of eviction fails.  Therefore, do not report an error
in host control mode if eviction fails.

Link: https://lore.kernel.org/r/20210808090024.21721-5-avri.altman@wdc.com
Fixes: 6c59cb501b86 (scsi: ufs: ufshpb: Make eviction depend on region's reads)
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index cd48367..aafb551 100644 (file)
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -1385,7 +1385,8 @@ static int ufshpb_add_region(struct ufshpb_lu *hpb, struct ufshpb_region *rgn)
                        victim_rgn = ufshpb_victim_lru_info(hpb);
                        if (!victim_rgn) {
                                dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
-                                   "cannot get victim region error\n");
+                                   "cannot get victim region %s\n",
+                                   hpb->is_hcm ? "" : "error");
                                ret = -ENOMEM;
                                goto out;
                        }