staging: rtl8723bs: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Wed, 29 Jul 2020 10:05:25 +0000 (11:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jul 2020 12:00:25 +0000 (14:00 +0200)
The variable ret is being assigned an error return value that is never
read, the control passes to a return statement and ret is never referenced.
Remove the redundant assignment. Also remove an empty line.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200729100525.573500-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/osdep_service.c

index 6d443197a0cf8966b453c68ea86ce67baea1029c..f61ad9200960dd8358c7e75004b614d72713af8d 100644 (file)
@@ -146,10 +146,8 @@ int rtw_change_ifname(struct adapter *padapter, const char *ifname)
        rereg_priv->old_pnetdev = cur_pnetdev;
 
        pnetdev = rtw_init_netdev(padapter);
-       if (!pnetdev)  {
-               ret = -1;
+       if (!pnetdev)
                goto error;
-       }
 
        SET_NETDEV_DEV(pnetdev, dvobj_to_dev(adapter_to_dvobj(padapter)));
 
@@ -170,9 +168,7 @@ int rtw_change_ifname(struct adapter *padapter, const char *ifname)
        return 0;
 
 error:
-
        return -1;
-
 }
 
 void rtw_buf_free(u8 **buf, u32 *buf_len)