[Non-ACR] Coverity Fixes in Test App 40/246440/1
authorDewal Agarwal <d1.agarwal@samsung.com>
Thu, 29 Oct 2020 08:33:03 +0000 (14:03 +0530)
committerDewal Agarwal <d1.agarwal@samsung.com>
Thu, 29 Oct 2020 08:33:03 +0000 (14:03 +0530)
- Resource Leak
- Unused Code

Change-Id: Icd75864f32cc539482dce236f96525c5cb5b2444

test/test_cli_app/src/bmt_usage.c

index 08f6750ddef7d11984cc33384fd46ea4a46f8bd2..ea1d8d533567ca0ed0474b7750128b6254c803ba 100644 (file)
@@ -211,9 +211,6 @@ static gboolean bmt_testapp_get_total_power_usage_by_app_id_for_all_resource_id_
                        case BATTERY_MONITOR_RESOURCE_ID_GPS_SENSOR:
                                testapp_print ("Resource ID : GPS App Usage Value = [%lf] \n", battery_usage);
                                break;
-                       default:
-                               testapp_print ("Default Case");
-                               break;
                        }
                }
        }
@@ -389,9 +386,6 @@ static gboolean bmt_testapp_get_power_usage_for_all_resource_id()
                case BATTERY_MONITOR_RESOURCE_ID_GPS_SENSOR:
                        testapp_print ("Resource ID : GPS Usage Value = [%lf] \n", battery_usage);
                        break;
-               default:
-                       testapp_print ("Default Case \n");
-                       break;
                }
 
        }
@@ -449,9 +443,6 @@ bool get_app_id_all_resource_cb(app_info_h app_info, void *user_data)
                        case BATTERY_MONITOR_RESOURCE_ID_GPS_SENSOR:
                                testapp_print ("Resource ID : GPS App Usage Value = [%lf] \n", battery_usage);
                                break;
-                       default:
-                               testapp_print ("Default Case");
-                               break;
                        }
                }
                battery_monitor_battery_usage_data_destroy(data_handle);
@@ -515,8 +506,10 @@ bool bmt_testapp_get_power_usage_automated()
                        start_time = s_t;
                        end_time = e_t;
                }
-               else
+               else {
+                       free(user_data);
                        return FALSE;
+               }
 
                testapp_print("\n Start Time: %ld \n", start_time);
                testapp_print("\n End Time: %ld \n", end_time);
@@ -557,9 +550,6 @@ bool bmt_testapp_get_power_usage_automated()
                        case BATTERY_MONITOR_RESOURCE_ID_GPS_SENSOR:
                                testapp_print ("Resource ID : GPS Usage Value = [%lf] \n", battery_usage);
                                break;
-                       default:
-                               testapp_print ("Default Case \n");
-                               break;
                        }
                }
                i++;