drm: simpledrm: Fix use after free issues

There are two occurrances where objects are being free'd via
a put call and yet they are being referenced after this. Fix these
by adding in the missing continue statement so that the put on the
end of the loop is skipped over.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Addresses-Coverity: ("Use after free")
Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
Link: https://patchwork.freedesktop.org/patch/msgid/20210512203051.299026-1-colin.king@canonical.com

diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index 00e118c6e2e8c7c30cfa8ed62d6205c0df9baf29..f72ca3a1c2d46938d1e3a196509d2da140f7b848 100644 (file)
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -298,6 +298,7 @@ static int simpledrm_device_init_clocks(struct simpledrm_device *sdev)
                        drm_err(dev, "failed to enable clock %u: %d\n",
                                i, ret);
                        clk_put(clock);
+                       continue;
                }
                sdev->clks[i] = clock;
        }
@@ -415,6 +416,7 @@ static int simpledrm_device_init_regulators(struct simpledrm_device *sdev)
                        drm_err(dev, "failed to enable regulator %u: %d\n",
                                i, ret);
                        regulator_put(regulator);
+                       continue;
                }
 
                sdev->regulators[i++] = regulator;