apparmorfs: Combine two function calls into one in aa_fs_seq_raw_abi_show()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 7 May 2017 11:43:50 +0000 (13:43 +0200)
committerJohn Johansen <john.johansen@canonical.com>
Thu, 8 Jun 2017 18:20:58 +0000 (11:20 -0700)
A bit of data was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: John Johansen <john.johansen@canonical.com>
security/apparmor/apparmorfs.c

index 4f6ac9d..b4d83e0 100644 (file)
@@ -572,10 +572,9 @@ static int aa_fs_seq_raw_abi_show(struct seq_file *seq, void *v)
        struct aa_proxy *proxy = seq->private;
        struct aa_profile *profile = aa_get_profile_rcu(&proxy->profile);
 
-       if (profile->rawdata->abi) {
-               seq_printf(seq, "v%d", profile->rawdata->abi);
-               seq_puts(seq, "\n");
-       }
+       if (profile->rawdata->abi)
+               seq_printf(seq, "v%d\n", profile->rawdata->abi);
+
        aa_put_profile(profile);
 
        return 0;