rtc: ds1307: use sysfs_emit() to instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Mon, 5 Dec 2022 03:34:45 +0000 (11:34 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 15 Dec 2022 22:34:31 +0000 (23:34 +0100)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212051134455911470@zte.com.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1307.c

index 7c2276cf5514a8f04f677d6d5f73dabab1ec31dd..def9b7f9d9577e9dad4052b781f5bfaddbfc5813 100644 (file)
@@ -1219,8 +1219,7 @@ static ssize_t frequency_test_show(struct device *dev,
 
        regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);
 
-       return scnprintf(buf, PAGE_SIZE, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" :
-                       "off\n");
+       return sysfs_emit(buf, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" : "off\n");
 }
 
 static DEVICE_ATTR_RW(frequency_test);