staging: rtl8187se: use netdev_warn instead of printk
authorTeodora Baluta <teobaluta@gmail.com>
Mon, 21 Oct 2013 23:37:24 +0000 (02:37 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Oct 2013 21:17:58 +0000 (14:17 -0700)
This patch fixes this type of checkpatch warnings:

WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
pr_warn(...  to printk(KERN_WARNING ...

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c

index ba32df9..f5a5219 100644 (file)
@@ -341,8 +341,7 @@ int ieee80211_rtl_xmit(struct sk_buff *skb,
             !(ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)) ||
            ((!ieee->softmac_data_hard_start_xmit &&
              (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
-               printk(KERN_WARNING "%s: No xmit handler.\n",
-                      ieee->dev->name);
+               netdev_warn(ieee->dev, "No xmit handler.\n");
                goto success;
        }
 
@@ -350,8 +349,7 @@ int ieee80211_rtl_xmit(struct sk_buff *skb,
        if (likely(ieee->raw_tx == 0)){
 
                if (unlikely(skb->len < SNAP_SIZE + sizeof(u16))) {
-                       printk(KERN_WARNING "%s: skb too small (%d).\n",
-                       ieee->dev->name, skb->len);
+                       netdev_warn(ieee->dev, "skb too small (%d).\n", skb->len);
                        goto success;
                }
 
@@ -475,8 +473,7 @@ int ieee80211_rtl_xmit(struct sk_buff *skb,
                 */
                txb = ieee80211_alloc_txb(nr_frags, frag_size, GFP_ATOMIC);
                if (unlikely(!txb)) {
-                       printk(KERN_WARNING "%s: Could not allocate TXB\n",
-                       ieee->dev->name);
+                       netdev_warn(ieee->dev, "Could not allocate TXB\n");
                        goto failed;
                }
                txb->encrypted = encrypt;
@@ -555,15 +552,13 @@ int ieee80211_rtl_xmit(struct sk_buff *skb,
                }
        } else {
                if (unlikely(skb->len < sizeof(struct ieee80211_hdr_3addr))) {
-                       printk(KERN_WARNING "%s: skb too small (%d).\n",
-                       ieee->dev->name, skb->len);
+                       netdev_warn(ieee->dev, "skb too small (%d).\n", skb->len);
                        goto success;
                }
 
                txb = ieee80211_alloc_txb(1, skb->len, GFP_ATOMIC);
                if (!txb) {
-                       printk(KERN_WARNING "%s: Could not allocate TXB\n",
-                       ieee->dev->name);
+                       netdev_warn(ieee->dev, "Could not allocate TXB\n");
                        goto failed;
                }