tty: serial: qcom-geni-serial: Fix %lu -> %u in print statements
authorDouglas Anderson <dianders@chromium.org>
Tue, 2 Aug 2022 20:23:09 +0000 (13:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Aug 2022 06:23:35 +0000 (08:23 +0200)
When we multiply an unsigned int by a u32 we still end up with an
unsigned int. That means we should specify "%u" not "%lu" in the
format code.

NOTE: this fix was chosen instead of somehow promoting the value to
"unsigned long" since the max baud rate from the earlier call to
uart_get_baud_rate() is 4000000 and the max sampling rate is 32.
4000000 * 32 = 0x07a12000, not even close to overflowing 32-bits.

Fixes: c474c775716e ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
Reported-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index f754619..f7c1f18 100644 (file)
@@ -1033,12 +1033,12 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
                sampling_rate, &clk_div);
        if (!clk_rate) {
                dev_err(port->se.dev,
-                       "Couldn't find suitable clock rate for %lu\n",
+                       "Couldn't find suitable clock rate for %u\n",
                        baud * sampling_rate);
                goto out_restart_rx;
        }
 
-       dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
+       dev_dbg(port->se.dev, "desired_rate-%u, clk_rate-%lu, clk_div-%u\n",
                        baud * sampling_rate, clk_rate, clk_div);
 
        uport->uartclk = clk_rate;