media: cec: set ev rather than v with CEC_PIN_EVENT_FL_DROPPED bit
authorColin Ian King <colin.king@canonical.com>
Wed, 18 Apr 2018 15:26:19 +0000 (11:26 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 20 Apr 2018 12:37:35 +0000 (08:37 -0400)
Setting v with the CEC_PIN_EVENT_FL_DROPPED is incorrect, instead
ev should be set with this bit. Fix this.

Detected by CoverityScan, CID#1467974 ("Extra high-order bits")

Fixes: 6ec1cbf6b125 ("media: cec: improve CEC pin event handling")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/cec/cec-pin.c

index 2a5df99..6e31142 100644 (file)
@@ -119,7 +119,7 @@ static void cec_pin_update(struct cec_pin *pin, bool v, bool force)
 
                if (pin->work_pin_events_dropped) {
                        pin->work_pin_events_dropped = false;
-                       v |= CEC_PIN_EVENT_FL_DROPPED;
+                       ev |= CEC_PIN_EVENT_FL_DROPPED;
                }
                pin->work_pin_events[pin->work_pin_events_wr] = ev;
                pin->work_pin_ts[pin->work_pin_events_wr] = ktime_get();