perf test: Use machine__new_host in mmap thread code reading test
authorJiri Olsa <jolsa@kernel.org>
Thu, 3 Dec 2015 08:34:14 +0000 (09:34 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 7 Dec 2015 21:12:55 +0000 (18:12 -0300)
This is more straightforward than what we have now.

It also fixes a segfault within machine__exit, that's caused
by not creating kernel maps for machine.. We're calling
machine__destroy_kernel_maps in machine__exit since commit:

  ebe9729c8c31 perf machine: Fix to destroy kernel maps when machine exits

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1449131658-1841-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/code-reading.c

index 4417b6a..26182ff 100644 (file)
@@ -433,7 +433,6 @@ enum {
 
 static int do_test_code_reading(bool try_kcore)
 {
-       struct machines machines;
        struct machine *machine;
        struct thread *thread;
        struct record_opts opts = {
@@ -459,8 +458,7 @@ static int do_test_code_reading(bool try_kcore)
 
        pid = getpid();
 
-       machines__init(&machines);
-       machine = &machines.host;
+       machine = machine__new_host();
 
        ret = machine__create_kernel_maps(machine);
        if (ret < 0) {
@@ -594,9 +592,8 @@ out_err:
                cpu_map__put(cpus);
                thread_map__put(threads);
        }
-       machines__destroy_kernel_maps(&machines);
        machine__delete_threads(machine);
-       machines__exit(&machines);
+       machine__delete(machine);
 
        return err;
 }