staging: rtl8723bs: Remove set but not used variables 'ppp', 'type', 'data'
authorzhengbin <zhengbin13@huawei.com>
Sun, 6 Oct 2019 09:09:58 +0000 (17:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 10:31:33 +0000 (12:31 +0200)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/staging/rtl8723bs/core/rtw_recv.c: In function validate_80211w_mgmt:
drivers/staging/rtl8723bs/core/rtw_recv.c:1415:8: warning: variable ppp set but not used [-Wunused-but-set-variable]
drivers/staging/rtl8723bs/core/rtw_recv.c: In function validate_80211w_mgmt:
drivers/staging/rtl8723bs/core/rtw_recv.c:1403:5: warning: variable type set but not used [-Wunused-but-set-variable]
drivers/staging/rtl8723bs/core/rtw_recv.c: In function recvframe_defrag:
drivers/staging/rtl8723bs/core/rtw_recv.c:1713:6: warning: variable data set but not used [-Wunused-but-set-variable]

They are not used since commit 554c0a3abf21 ("staging:
Add rtl8723bs sdio wifi driver")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Link: https://lore.kernel.org/r/1570352999-45790-5-git-send-email-zhengbin13@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_recv.c

index 687ff3c..7fa8c84 100644 (file)
@@ -1400,10 +1400,8 @@ static sint validate_80211w_mgmt(struct adapter *adapter, union recv_frame *prec
        struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
        struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
        u8 *ptr = precv_frame->u.hdr.rx_data;
-       u8 type;
        u8 subtype;
 
-       type =  GetFrameType(ptr);
        subtype = GetFrameSubType(ptr); /* bit(7)~bit(2) */
 
        /* only support station mode */
@@ -1412,9 +1410,8 @@ static sint validate_80211w_mgmt(struct adapter *adapter, union recv_frame *prec
                /* unicast management frame decrypt */
                if (pattrib->privacy && !(IS_MCAST(GetAddr1Ptr(ptr))) &&
                        (subtype == WIFI_DEAUTH || subtype == WIFI_DISASSOC || subtype == WIFI_ACTION)) {
-                       u8 *ppp, *mgmt_DATA;
+                       u8 *mgmt_DATA;
                        u32 data_len = 0;
-                       ppp = GetAddr2Ptr(ptr);
 
                        pattrib->bdecrypted = 0;
                        pattrib->encrypt = _AES_;
@@ -1709,7 +1706,7 @@ static union recv_frame *recvframe_defrag(struct adapter *adapter,
                                          struct __queue *defrag_q)
 {
        struct list_head         *plist, *phead;
-       u8 *data, wlanhdr_offset;
+       u8  wlanhdr_offset;
        u8 curfragnum;
        struct recv_frame_hdr *pfhdr, *pnfhdr;
        union recv_frame *prframe, *pnextrframe;
@@ -1739,8 +1736,6 @@ static union recv_frame *recvframe_defrag(struct adapter *adapter,
 
        plist = get_next(plist);
 
-       data = get_recvframe_data(prframe);
-
        while (phead != plist) {
                pnextrframe = (union recv_frame *)plist;
                pnfhdr = &pnextrframe->u.hdr;