perf c2c: Use more explicit headers for HITM
authorLeo Yan <leo.yan@linaro.org>
Wed, 14 Oct 2020 05:09:18 +0000 (06:09 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 15 Oct 2020 12:34:47 +0000 (09:34 -0300)
Local and remote HITM use the headers 'Lcl' and 'Rmt' respectively,
suppose if we want to extend the tool to display these two dimensions
under any one metrics, users cannot understand the semantics if only
based on the header string 'Lcl' or 'Rmt'.

To explicit express the meaning for HITM items, this patch changes the
headers string as "LclHitm" and "RmtHitm", the strings are more readable
and this allows to extend metrics for using HITM items.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Tested-by: Joe Mario <jmario@redhat.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20201014050921.5591-6-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-c2c.c

index 93f2d6c..05eeca2 100644 (file)
@@ -1336,7 +1336,7 @@ static struct c2c_dimension dim_tot_hitm = {
 };
 
 static struct c2c_dimension dim_lcl_hitm = {
-       .header         = HEADER_SPAN_LOW("Lcl"),
+       .header         = HEADER_SPAN_LOW("LclHitm"),
        .name           = "lcl_hitm",
        .cmp            = lcl_hitm_cmp,
        .entry          = lcl_hitm_entry,
@@ -1344,7 +1344,7 @@ static struct c2c_dimension dim_lcl_hitm = {
 };
 
 static struct c2c_dimension dim_rmt_hitm = {
-       .header         = HEADER_SPAN_LOW("Rmt"),
+       .header         = HEADER_SPAN_LOW("RmtHitm"),
        .name           = "rmt_hitm",
        .cmp            = rmt_hitm_cmp,
        .entry          = rmt_hitm_entry,
@@ -1486,7 +1486,7 @@ static struct c2c_dimension dim_percent_hitm = {
 };
 
 static struct c2c_dimension dim_percent_rmt_hitm = {
-       .header         = HEADER_SPAN("----- HITM -----", "Rmt", 1),
+       .header         = HEADER_SPAN("----- HITM -----", "RmtHitm", 1),
        .name           = "percent_rmt_hitm",
        .cmp            = percent_rmt_hitm_cmp,
        .entry          = percent_rmt_hitm_entry,
@@ -1495,7 +1495,7 @@ static struct c2c_dimension dim_percent_rmt_hitm = {
 };
 
 static struct c2c_dimension dim_percent_lcl_hitm = {
-       .header         = HEADER_SPAN_LOW("Lcl"),
+       .header         = HEADER_SPAN_LOW("LclHitm"),
        .name           = "percent_lcl_hitm",
        .cmp            = percent_lcl_hitm_cmp,
        .entry          = percent_lcl_hitm_entry,