staging: rtl8188eu: Remove function rtw_alloc_etherdev()
authornavin patidar <navin.patidar@gmail.com>
Thu, 10 Jul 2014 03:42:17 +0000 (09:12 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2014 04:15:21 +0000 (21:15 -0700)
rtw_alloc_etherdev() is used in rtw_init_netdev() but never gets called
because old_padapter is never NULL.

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/include/osdep_service.h
drivers/staging/rtl8188eu/os_dep/os_intfs.c
drivers/staging/rtl8188eu/os_dep/osdep_service.c

index 95131fe..a52dcd5 100644 (file)
@@ -164,7 +164,6 @@ struct rtw_netdev_priv_indicator {
 };
 struct net_device *rtw_alloc_etherdev_with_old_priv(int sizeof_priv,
                                                    void *old_priv);
-struct net_device *rtw_alloc_etherdev(int sizeof_priv);
 
 #define rtw_netdev_priv(netdev)                                        \
        (((struct rtw_netdev_priv_indicator *)netdev_priv(netdev))->priv)
index b0c38a4..c7a44ab 100644 (file)
@@ -707,14 +707,12 @@ static const struct device_type wlan_type = {
 struct net_device *rtw_init_netdev(struct adapter *old_padapter)
 {
        struct adapter *padapter;
-       struct net_device *pnetdev;
+       struct net_device *pnetdev = NULL;
 
        RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+init_net_dev\n"));
 
        if (old_padapter != NULL)
                pnetdev = rtw_alloc_etherdev_with_old_priv(sizeof(struct adapter), (void *)old_padapter);
-       else
-               pnetdev = rtw_alloc_etherdev(sizeof(struct adapter));
 
        if (!pnetdev)
                return NULL;
index 76eddcd..93c76d7 100644 (file)
@@ -111,29 +111,6 @@ RETURN:
        return pnetdev;
 }
 
-struct net_device *rtw_alloc_etherdev(int sizeof_priv)
-{
-       struct net_device *pnetdev;
-       struct rtw_netdev_priv_indicator *pnpi;
-
-       pnetdev = alloc_etherdev_mq(sizeof(struct rtw_netdev_priv_indicator), 4);
-       if (!pnetdev)
-               goto RETURN;
-
-       pnpi = netdev_priv(pnetdev);
-
-       pnpi->priv = vzalloc(sizeof_priv);
-       if (!pnpi->priv) {
-               free_netdev(pnetdev);
-               pnetdev = NULL;
-               goto RETURN;
-       }
-
-       pnpi->sizeof_priv = sizeof_priv;
-RETURN:
-       return pnetdev;
-}
-
 void rtw_free_netdev(struct net_device *netdev)
 {
        struct rtw_netdev_priv_indicator *pnpi;