Fix possibility of double free 30/198630/5
authorilho <ilho159.kim@samsung.com>
Mon, 28 Jan 2019 07:52:32 +0000 (16:52 +0900)
committerilho <ilho159.kim@samsung.com>
Mon, 28 Jan 2019 23:48:54 +0000 (08:48 +0900)
Change-Id: I907211b9896d3de040c4da76778c942ff7890c75
Signed-off-by: ilho <ilho159.kim@samsung.com>
installer/pkgmgr_installer.c

index a15485f..f69db39 100644 (file)
@@ -459,10 +459,12 @@ pkgmgr_installer_receive_request(pkgmgr_installer *pi,
                                free(pi->pkgmgr_info);
                        pi->pkgmgr_info = strndup(optarg, MAX_STRLEN);
                        DBG("option is [i] pkgid[%s]", pi->pkgmgr_info);
-                       if (pi->pkgmgr_info && strlen(pi->pkgmgr_info) == 0)
+                       if (pi->pkgmgr_info && strlen(pi->pkgmgr_info) == 0) {
                                free(pi->pkgmgr_info);
-                       else
+                               pi->pkgmgr_info = NULL;
+                       } else {
                                mode = 'i';
+                       }
                        break;
 
                case 'e':       /* install */