string_decoder: don't cache Buffer.isEncoding

Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: https://github.com/iojs/io.js/issues/1547
PR-URL: https://github.com/iojs/io.js/pull/1548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

diff --git a/lib/string_decoder.js b/lib/string_decoder.js
index 61a3bb2..62ea38e 100644 (file)
--- a/lib/string_decoder.js
+++ b/lib/string_decoder.js
@@ -1,9 +1,9 @@
 'use strict';
 
-const isEncoding = Buffer.isEncoding;
-
 function assertEncoding(encoding) {
-  if (encoding && !isEncoding(encoding)) {
+  // Do not cache `Buffer.isEncoding`, some modules monkey-patch it to support
+  // additional encodings
+  if (encoding && !Buffer.isEncoding(encoding)) {
     throw new Error('Unknown encoding: ' + encoding);
   }
 }