// Self-check: Code compares something with 'this' pointer. We don't check
// whether it is actually the parameter what we compare.
- const auto HasNoSelfCheck = cxxMethodDecl(unless(
+ const auto HasNoSelfCheck = cxxMethodDecl(unless(anyOf(
hasDescendant(binaryOperator(hasAnyOperatorName("==", "!="),
- has(ignoringParenCasts(cxxThisExpr()))))));
+ has(ignoringParenCasts(cxxThisExpr())))),
+ hasDescendant(cxxOperatorCallExpr(
+ hasAnyOverloadedOperatorName("==", "!="), argumentCountIs(2),
+ has(ignoringParenCasts(cxxThisExpr())))))));
// Both copy-and-swap and copy-and-move method creates a copy first and
// assign it to 'this' with swap or move.
T *p;
};
+// https://bugs.llvm.org/show_bug.cgi?id=44499
+class Foo2;
+template <int a>
+bool operator!=(Foo2 &, Foo2 &) {
+ class Bar2 {
+ Bar2 &operator=(const Bar2 &other) {
+ // CHECK-MESSAGES: [[@LINE-1]]:11: warning: operator=() does not handle self-assignment properly [bugprone-unhandled-self-assignment]
+ p = other.p;
+ return *this;
+ }
+
+ int *p;
+ };
+}
+
///////////////////////////////////////////////////////////////////
/// Test cases correctly ignored by the check.
T *p;
};
+// https://bugs.llvm.org/show_bug.cgi?id=44499
+class Foo;
+template <int a>
+bool operator!=(Foo &, Foo &) {
+ class Bar {
+ Bar &operator=(const Bar &other) {
+ if (this != &other) {
+ }
+ return *this;
+ }
+
+ int *p;
+ };
+}
+
// There is no warning if the copy assignment operator gets the object by value.
class PassedByValue {
public: