erofs-utils: fsck: fix fd leak on failure in erofs_extract_file()
authorGao Xiang <hsiangkao@linux.alibaba.com>
Fri, 2 Aug 2024 01:55:25 +0000 (09:55 +0800)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Sun, 4 Aug 2024 01:51:02 +0000 (09:51 +0800)
Ignore the return values as other close()s instead.

Coverity-id: 502331
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240802015527.2113797-1-hsiangkao@linux.alibaba.com
fsck/main.c

index fb669673a39ef2091fb7141eaa858c4f7fd0ba90..28f1e7e6db1385b82748e1fd0756fa11959c7f4d 100644 (file)
@@ -702,11 +702,7 @@ again:
 
        /* verify data chunk layout */
        ret = erofs_verify_inode_data(inode, fd);
-       if (ret)
-               return ret;
-
-       if (close(fd))
-               return -errno;
+       close(fd);
        return ret;
 }