hwmon: (coretemp) avoid RDMSR interrupts to isolated CPUs
authorMarcelo Tosatti <mtosatti@redhat.com>
Fri, 16 Dec 2022 20:24:08 +0000 (17:24 -0300)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 3 Feb 2023 15:30:09 +0000 (07:30 -0800)
The coretemp driver uses rdmsr_on_cpu calls to read
MSR_IA32_PACKAGE_THERM_STATUS/MSR_IA32_THERM_STATUS registers,
which contain information about current core temperature.

For certain low latency applications, the RDMSR interruption exceeds
the applications requirements.

So do not create core files in sysfs, for CPUs which have
isolation and nohz_full enabled.

Temperature information from the housekeeping cores should be
sufficient to infer die temperature.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Link: https://lore.kernel.org/r/Y5zT6B1mY9/pnwJV@tpad
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/coretemp.c

index ca7a9b3..49091ea 100644 (file)
@@ -27,6 +27,7 @@
 #include <asm/msr.h>
 #include <asm/processor.h>
 #include <asm/cpu_device_id.h>
+#include <linux/sched/isolation.h>
 
 #define DRVNAME        "coretemp"
 
@@ -502,6 +503,9 @@ static int create_core_data(struct platform_device *pdev, unsigned int cpu,
        u32 eax, edx;
        int err, index, attr_no;
 
+       if (!housekeeping_cpu(cpu, HK_TYPE_MISC))
+               return 0;
+
        /*
         * Find attr number for sysfs:
         * We map the attr number to core id of the CPU