serial: liteuart: Fix NULL pointer dereference in ->remove()
authorIlia Sergachev <silia@ethz.ch>
Mon, 15 Nov 2021 21:49:44 +0000 (22:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Nov 2021 17:25:24 +0000 (18:25 +0100)
drvdata has to be set in _probe() - otherwise platform_get_drvdata()
causes null pointer dereference BUG in _remove().

Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ilia Sergachev <silia@ethz.ch>
Link: https://lore.kernel.org/r/20211115224944.23f8c12b@dtkw
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/liteuart.c

index dbc0559..f075f4f 100644 (file)
@@ -285,6 +285,8 @@ static int liteuart_probe(struct platform_device *pdev)
        port->line = dev_id;
        spin_lock_init(&port->lock);
 
+       platform_set_drvdata(pdev, port);
+
        return uart_add_one_port(&liteuart_driver, &uart->port);
 }