fix coverity

	CID-111024 Unchecked return value
	CID-110444 Resource leak
	CID-110342 Resource leak
	CID-108973 Resource leak
	CID-107052 Resource leak

Change-Id: I4dc600bd5e48cefefd02e43599f869ce2162835f
Signed-off-by: sangho park <sangho.g.park@samsung.com>

diff --git a/mv_face/face/src/mv_face_open.cpp b/mv_face/face/src/mv_face_open.cpp
index 337b8b84ae5083fdae7cbb3fcdd50904655493c2..65313637ebc2ec9d8fdd002f09114cbeae718b8f 100644 (file)
--- a/mv_face/face/src/mv_face_open.cpp
+++ b/mv_face/face/src/mv_face_open.cpp
@@ -40,7 +40,9 @@ static void extractRecognitionParams(
        mv_engine_config_h working_cfg = NULL;
 
        if (NULL == engine_cfg) {
-               mv_create_engine_config(&working_cfg);
+               if (MEDIA_VISION_ERROR_NONE == mv_create_engine_config(&working_cfg)) {
+                       LOGI("mv_create_engine_config is called");
+               }
        } else {
                working_cfg = engine_cfg;
        }

diff --git a/mv_surveillance/surveillance/src/EventTriggerPersonRecognition.cpp b/mv_surveillance/surveillance/src/EventTriggerPersonRecognition.cpp
index 5dd9d09030313f9ed82c3f0f4cc837f4cc8ced62..5fbf6073de752bcd6b969e66a7f138766c1af7cf 100644 (file)
--- a/mv_surveillance/surveillance/src/EventTriggerPersonRecognition.cpp
+++ b/mv_surveillance/surveillance/src/EventTriggerPersonRecognition.cpp
@@ -163,6 +163,12 @@ int EventTriggerPersonRecognition::parseEngineConfig(mv_engine_config_h engineCo
                        modelPath = NULL;
                }
 
+               const int err = mv_face_recognition_model_destroy(recognitionModel);
+               if (MEDIA_VISION_ERROR_NONE != err) {
+                       LOGE("Error while trying to delete face recognition model."
+                                       " Error code: %i.", err);
+               }
+
                return error;
        }
 

diff --git a/packaging/capi-media-vision.spec b/packaging/capi-media-vision.spec
index 49f58982d87e9da7530ea985c63fcfe014419400..5d73ca5c4a87d049c00744fb0389ad74f2a63eea 100644 (file)
--- a/packaging/capi-media-vision.spec
+++ b/packaging/capi-media-vision.spec
@@ -1,6 +1,6 @@
 Name:        capi-media-vision
 Summary:     Media Vision library for Tizen Native API
-Version:     0.3.28
+Version:     0.3.29
 Release:     1
 Group:       Multimedia/Framework
 License:     Apache-2.0 and BSD-3-Clause

diff --git a/test/testsuites/face/face_test_suite.c b/test/testsuites/face/face_test_suite.c
index 7db95609050f400c85f9366b8573cb45b52b8a95..c170246bf915fdd39cdc24a8a9714de9c9bc5a9a 100644 (file)
--- a/test/testsuites/face/face_test_suite.c
+++ b/test/testsuites/face/face_test_suite.c
@@ -254,6 +254,13 @@ int perform_detect()
 
                free(out_file_name);
 
+               const int err2 = mv_destroy_source(source);
+               if (MEDIA_VISION_ERROR_NONE != err2) {
+                       printf(TEXT_RED
+                                       "ERROR: Errors were occurred during destroying the source!!! code: %i"
+                                       TEXT_RESET "\n", err2);
+               }
+
                return err;
        }
 
@@ -1598,6 +1605,13 @@ void track_on_sample_cb(
                printf(TEXT_RED "ERROR: Errors were occurred during filling the source "
                                "based on the video frame! Error code: %i\n" TEXT_RESET , err);
 
+               const int err2 = mv_destroy_source(source);
+               if (MEDIA_VISION_ERROR_NONE != err2) {
+                       printf(TEXT_RED
+                                       "ERROR: Errors were occurred during destroying the source!!! code: %i"
+                                       TEXT_RESET "\n", err2);
+               }
+
                return;
        }
 

diff --git a/test/testsuites/surveillance/surveillance_test_suite.c b/test/testsuites/surveillance/surveillance_test_suite.c
index b8cce60cf04ff345034ccf55e3492ccaad0ee209..82373e2f5bdee437a70208dda89fde5f6d6a2d77 100644 (file)
--- a/test/testsuites/surveillance/surveillance_test_suite.c
+++ b/test/testsuites/surveillance/surveillance_test_suite.c
@@ -577,6 +577,11 @@ void push_source()
 
        if (MEDIA_VISION_ERROR_NONE != error) {
                PRINT_E("Errors were occurred during source loading, code %i", error);
+               int error2 = mv_destroy_source(source);
+               if (MEDIA_VISION_ERROR_NONE != error2) {
+                       PRINT_E("Errors were occurred during source destroying, code %i", error2);
+               }
+
                return;
        }