Name threads properly
authormae <matthias.ettrich@nokia.com>
Thu, 1 Mar 2012 18:42:50 +0000 (19:42 +0100)
committerQt by Nokia <qt-info@nokia.com>
Fri, 2 Mar 2012 22:16:25 +0000 (23:16 +0100)
When there is no QObject subclass with Q_OBJECT macro,
we must at least set an object name

Change-Id: Ib429a9b246d9d6b4b4cfb11593e4f358850677f2
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
src/network/access/qnetworkreplyhttpimpl.cpp
src/network/bearer/qnetworkconfigmanager_p.cpp

index a4413cd..2124395 100644 (file)
@@ -607,12 +607,14 @@ void QNetworkReplyHttpImplPrivate::postRequest()
     if (synchronous) {
         // A synchronous HTTP request uses its own thread
         thread = new QThread();
+        thread->setObjectName(QStringLiteral("httpReply"));
         QObject::connect(thread, SIGNAL(finished()), thread, SLOT(deleteLater()));
         thread->start();
     } else if (!managerPrivate->httpThread) {
         // We use the manager-global thread.
         // At some point we could switch to having multiple threads if it makes sense.
         managerPrivate->httpThread = new QThread();
+        managerPrivate->httpThread->setObjectName(QStringLiteral("httpThread"));
         QObject::connect(managerPrivate->httpThread, SIGNAL(finished()), managerPrivate->httpThread, SLOT(deleteLater()));
         managerPrivate->httpThread->start();
 
index 25bf21e..d152adc 100644 (file)
@@ -70,6 +70,8 @@ void QNetworkConfigurationManagerPrivate::initialize()
 {
     //Two stage construction, because we only want to do this heavyweight work for the winner of the Q_GLOBAL_STATIC race.
     bearerThread = new QThread();
+    bearerThread->setObjectName(QStringLiteral("bearerThread"));
+
     bearerThread->moveToThread(QCoreApplicationPrivate::mainThread()); // because cleanup() is called in main thread context.
     moveToThread(bearerThread);
     bearerThread->start();