Show text selection handlers when hostkeyboard is ON.
authorGurpreet Kaur <k.gurpreet@samsung.com>
Mon, 28 Oct 2013 10:33:11 +0000 (19:33 +0900)
committerGerrit Code Review <gerrit@gerrit.vlan144.tizendev.org>
Tue, 29 Oct 2013 08:22:28 +0000 (08:22 +0000)
[Version] common
[Title] Show text selection handlers when hostkeyboard is ON.
[BinType] N/A
[Customer] HQ
[Issue#] N_SE 56013, N_SE 55684, N_SE 56040
[Problem] Text selection handlers and context menu is not shown.
[Cause] Update handlers and context menu was not being called.
[Solution] While showing handlers and context menu IME state check was
           added which was not handled correctly. So added proper check.
[Team] WebCoreSupport
[Developer] k.gurpreet@samsung.com
[Request] N/A
[Horizontal expansion] N/A
[SCMRequest] NA

Change-Id: Idd62f03ca8662e5901d6babe34b932c0265083ba

Source/WebKit2/UIProcess/API/efl/tizen/TextSelection.cpp

index 9738ffa..e94b28d 100755 (executable)
@@ -578,8 +578,9 @@ void TextSelection::updateHandlesAndContextMenu(bool isShow, bool isScrolling)
         InputMethodContextEfl* inputMethodContext = m_viewImpl->inputMethodContext();
         if (inputMethodContext) {
             bool isIMEShow = InputMethodContextEfl::isSystemKeypadShow();
+            bool isHostKeyboardOn = InputMethodContextEfl::shouldUseExternalKeyboard();
             int isIMEState = inputMethodContext->state();
-            if (!isIMEShow && (isIMEState == ECORE_IMF_INPUT_PANEL_STATE_WILL_SHOW)) {
+            if (!isHostKeyboardOn && !isIMEShow && (isIMEState == ECORE_IMF_INPUT_PANEL_STATE_WILL_SHOW)) {
                 requestToShow();
                 return;
             }