Fix memory leaks

- fix a bugs from coverity test

Change-Id: I4bcc79b4b1163dca35fc104374375cc20a7b78fc
Signed-off-by: kiso.chang <kiso.chang@samsung.com>

diff --git a/setting-applications/src/setting-applications-defaultapp.c b/setting-applications/src/setting-applications-defaultapp.c
index bb7d3f7049ad29ef59101919318adef3600245dd..57dbbd6c4df7607476ef75cb376b870240a58a4c 100755 (executable)
--- a/setting-applications/src/setting-applications-defaultapp.c
+++ b/setting-applications/src/setting-applications-defaultapp.c
@@ -247,6 +247,8 @@ static void __construct_defaultapp(SettingApplications *ad, Evas_Object *genlist
                SETTING_TRACE_ERROR("ad->data_home is NULL");
        }
 
+       FREE(sub_desc);
+
        /* Create default app list */
        setting_create_Gendial_field_titleItem(genlist, &(ad->itc_grp_title),
                        MGRAPP_STR_CLEAR_DEFAULT, NULL);

diff --git a/setting-appmgr/src/setting-appmgr-main.c b/setting-appmgr/src/setting-appmgr-main.c
index eabb8bf5efc2d8bc7075fd4cbd7d338d89f68e67..3c963024f022325a7134efc40d588948acd52dfa 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-main.c
+++ b/setting-appmgr/src/setting-appmgr-main.c
@@ -202,8 +202,10 @@ static void _enable_app_apps_popup_cb(void *data, Evas_Object *obj,
                        continue;
 
                ret = package_info_create(package_id, &package_info);
-               if (PACKAGE_MANAGER_ERROR_NONE != ret)
+               if (PACKAGE_MANAGER_ERROR_NONE != ret){
+                       free(package_id);
                        continue;
+               }
 
                package_info_get_type(package_info, &type);
                package_info_destroy(package_info);
@@ -215,6 +217,8 @@ static void _enable_app_apps_popup_cb(void *data, Evas_Object *obj,
                pc_request = NULL;
                free(type);
                type = NULL;
+
+               free(package_id);
        }
        evas_object_del(ad->popup);
        ad->popup = NULL;

diff --git a/setting-appmgr/src/setting-appmgr-pkginfo.c b/setting-appmgr/src/setting-appmgr-pkginfo.c
index e63fed51b63e31787bd420409c4faab3c157f962..6706e0365328d56870bb425cf5e962a83d6a29ce 100755 (executable)
--- a/setting-appmgr/src/setting-appmgr-pkginfo.c
+++ b/setting-appmgr/src/setting-appmgr-pkginfo.c
@@ -753,9 +753,11 @@ static int _default_apps_cb(const char *appid, void *data)
 
        if (!safeStrCmp(pkg->id, package_id)) {
                pkg->is_default = true;
+               free(package_id);
                return -1;
        }
 
+       free(package_id);
        return 0;
 }
 

diff --git a/setting-ringtone/src/setting-ringtone-main.c b/setting-ringtone/src/setting-ringtone-main.c
index ae6ded423465e921159b36251aca416881f1fc21..95d36fd89f4b4c18bba35616fdd6a9bf1b5a10c0 100755 (executable)
--- a/setting-ringtone/src/setting-ringtone-main.c
+++ b/setting-ringtone/src/setting-ringtone-main.c
@@ -615,15 +615,13 @@ static void _create_main_ui_list(SettingRingtoneData *ad)
        Eina_List *l = NULL;
        fileNodeInfo *lnode_data = NULL;
        char *default_file_path = NULL;
-       char *full_path = NULL;
-       Setting_GenGroupItem_Data *item_data = NULL;
        int cnt = 0;
        int cur_pos = -1; /*current selected item */
 
-       full_path = (char *)alloca(PATH_MAX);
+       char *full_path = (char *)alloca(PATH_MAX);
        ret_if(full_path == NULL);
 
-       item_data = setting_create_Gendial_field_1radio(
+       Setting_GenGroupItem_Data *item_data = setting_create_Gendial_field_1radio(
                        ad->md.genlist, &(ad->itc_ring), _item_selected_cb,
                        ad, SWALLOW_Type_1RADIO_RIGHT, ad->common_radio_group,
                        cnt, NULL, NULL);
@@ -654,6 +652,8 @@ static void _create_main_ui_list(SettingRingtoneData *ad)
                if (lnode_data->path && lnode_data->name)
                        snprintf(full_path, PATH_MAX, "%s/%s",
                                        lnode_data->path, lnode_data->name);
+               else
+                       continue;
 
                /* Some external application has launched Ringtone.
                 * It has also pointed us to our default directory.